-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor doesn't allow to edit or preview non-active block themes #37201
Comments
More context can be found here: https://core.trac.wordpress.org/ticket/54578 |
In the latest exploration with theFSE Outreach Program, this idea came up:
For context, this is referring to this view added to Gutenberg in specific situations, like when switching style variations: #41156 I think it could be interesting to consider as a pathway when it comes to live preview/theme switching in general so noting here for consideration when this work gets underway. |
I think this is a solid initial step, especially since it mimics the site editor experience in a way that might perhaps create some familiarity. It also might tie in nicely if theme preview and switching gets baked into the broader Site Editor experience, rather than having something that would have to be later unified. I do wonder if we could add an "Activate & Publish" button, similar to the Customizer preview. Finally, I'd love to see how style variations could be incorporated as that's a big part of the future of theme switching to consider (mix and match + the ability to have "multiple themes" in a single theme in many ways). We already have a high level styles section in the same sidebar #49014 so I wonder what we can reuse here to really show off the power of block themes, especially since we show style variations in the Theme Directory. Until we have a library setup for patterns, I'm not quite sure how we can best demo those pieces. Thinking super long term, perhaps a zoomed out mode could be invoked in the preview along folks to switch between patterns provided by the theme. |
Tagging in @WordPress/gutenberg-design for this issue! |
Good issue. I would share Ben's instincts as far as the general flow, and add that there's an opportunity here to vastly improve the multi entity saving panel (maybe finally unify it on a modal). This is essentially where you "switch themes" in a block themes world, and furthermore it's a place where you can show checkboxes for what to keep from the old and new themes, whether patterns, templates, colors, fonts, etc. Also want to connect the dots to these mockups by @critterverse that are still very relevant to this: https://make.wordpress.org/design/2021/10/08/adventures-in-block-theme-switching/ |
What problem does this address?
Site Editor only works with an active block theme.
It's not possible to edit non-active block themes with it.
E.g., it's not possible to Live Preview non-active block themes.
What is your proposed solution?
It's simple: we need to implement that feature.
The text was updated successfully, but these errors were encountered: