-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to edit template part properties in focus mode #37220
Comments
I like the idea of the template tab but my concern is we are heading to multiple places for information. I get the desire to access important things, but you don't need access to everything in all places, so working out the interaction paths is key here and use cases. |
For me it's more a question of appropriate hierarchy. For example I don't know that it should be necessary to enter template part focus mode to change a template part properties, that could lead to some frustrating UX. So placing those options in the Advanced panel seems sensible. But since focus mode feels like the primary template part editing interface, it seems logical that fundamental properties like the name should be editable there too. |
In light of discussions elsewhere it might make sense to put these controls in the top toolbar, with a view removing the sad and empty "Template" tab from the insepctor.
If we need a short-term solution, it would probably be fine to put these controls (area / html element) in the Inspector. |
Noting that this came up with the recent FSE Outreach Program's usability testing as a big point of confusion. Someone created a new template part as a "general" item but named it "header new". Later, when in template part focus mode and when looking at the list of template parts, they tried to find a way to change the categorization but couldn't find an easy way to do so. |
This enhancement would be a requirement for #37943. Otherwise, users won't have access to the template part options. |
@jameskoster, I'm planning to start working on this (probably early next week). I noticed that the only properties we can edit in focus mode would be the WhyIn focus mode, we don't have access to the template part block, just its contents, so we cannot change attributes. However, the |
@Mamaduka makes sense, I think those are the most important attributes anyway 👍 |
When a template part is selected in the template editing view it's possible to edit its properties like
area
in the Advanced panel:It should also be possible to manage these properties whilst editing a tempalte part in focus mode. Perhaps in the currently-empty Template tab:
Or the template details popover:
The text was updated successfully, but these errors were encountered: