Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to edit template part properties in focus mode #37220

Closed
Tracked by #41241
jameskoster opened this issue Dec 8, 2021 · 7 comments · Fixed by #43151
Closed
Tracked by #41241

Make it possible to edit template part properties in focus mode #37220

jameskoster opened this issue Dec 8, 2021 · 7 comments · Fixed by #43151
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

When a template part is selected in the template editing view it's possible to edit its properties like area in the Advanced panel:

Screenshot 2021-12-08 at 10 57 27

It should also be possible to manage these properties whilst editing a tempalte part in focus mode. Perhaps in the currently-empty Template tab:

Screenshot 2021-12-08 at 10 58 23

Or the template details popover:

Screenshot 2021-12-08 at 10 59 40

@jameskoster jameskoster added Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Dec 8, 2021
@karmatosed
Copy link
Member

I like the idea of the template tab but my concern is we are heading to multiple places for information. I get the desire to access important things, but you don't need access to everything in all places, so working out the interaction paths is key here and use cases.

@jameskoster
Copy link
Contributor Author

jameskoster commented Jan 10, 2022

For me it's more a question of appropriate hierarchy. For example I don't know that it should be necessary to enter template part focus mode to change a template part properties, that could lead to some frustrating UX. So placing those options in the Advanced panel seems sensible.

But since focus mode feels like the primary template part editing interface, it seems logical that fundamental properties like the name should be editable there too.

@jameskoster jameskoster added the [Feature] Focus Mode Zoomed in focus mode for editing things like template parts label Jan 21, 2022
@jameskoster
Copy link
Contributor Author

In light of discussions elsewhere it might make sense to put these controls in the top toolbar, with a view removing the sad and empty "Template" tab from the insepctor.

Editing a post Editing a Template Part
Screenshot 2022-05-12 at 14 27 31 Screenshot 2022-05-12 at 14 27 46

If we need a short-term solution, it would probably be fine to put these controls (area / html element) in the Inspector.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels May 12, 2022
@jameskoster jameskoster added the [Block] Template Part Affects the Template Parts Block label Jun 24, 2022
@annezazu
Copy link
Contributor

Noting that this came up with the recent FSE Outreach Program's usability testing as a big point of confusion. Someone created a new template part as a "general" item but named it "header new". Later, when in template part focus mode and when looking at the list of template parts, they tried to find a way to change the categorization but couldn't find an easy way to do so.

@Mamaduka
Copy link
Member

This enhancement would be a requirement for #37943. Otherwise, users won't have access to the template part options.

@Mamaduka
Copy link
Member

Mamaduka commented Aug 5, 2022

@jameskoster, I'm planning to start working on this (probably early next week). I noticed that the only properties we can edit in focus mode would be the title and area.

Why

In focus mode, we don't have access to the template part block, just its contents, so we cannot change attributes. However, the title and area are stored in the entity, and we can change that.

@jameskoster
Copy link
Contributor Author

@Mamaduka makes sense, I think those are the most important attributes anyway 👍

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 11, 2022
@Mamaduka Mamaduka removed the Needs Dev Ready for, and needs developer efforts label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants