Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACF (Free) fields not displaying properly #3731

Closed
maddisondesigns opened this issue Nov 30, 2017 · 5 comments
Closed

ACF (Free) fields not displaying properly #3731

maddisondesigns opened this issue Nov 30, 2017 · 5 comments
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@maddisondesigns
Copy link

Issue Overview

I created three simply custom fields. An input field, a text area and a TinyMCe field. The TinyMCE field isn't displaying correctly. There's no toolbar buttons displaying. Not only that, but the field is incredibly long.

There are also adhoc icons displaying at the bottom left-hand of the screen. I don't know if these icons are from the TinyMCE field or whether they're from Gutenberg

screenshot_540

Steps to Reproduce (for bugs)

  1. Install ACF
  2. Add new Field Group
  3. Create a TinyMCE (WYSIWYG) field
  4. Set Field Group to display on Pages
  5. Edit a page and view the custom fields that don't display properly

Expected Behavior

I expect to see all my ACF fields being displayed properly

Current Behavior

Not all ACF fierlds are being displyed properly

Related Issues and/or PRs

#3728

Firefox Quantum 57.0
Gutenberg Version 1.8.1
macOS Sierra 10.12.1

@chthonic-ds
Copy link
Contributor

chthonic-ds commented Nov 30, 2017

Related: #3302

This display issue with a TinyMCE/WYSIWYG field occurs for the Pods and Custom Field Suite plugins as well.

@maddisondesigns maddisondesigns changed the title ACF (Free) fields not diaplying properly ACF (Free) fields not dispalying properly Nov 30, 2017
@maddisondesigns maddisondesigns changed the title ACF (Free) fields not dispalying properly ACF (Free) fields not displaying properly Nov 30, 2017
@youknowriad
Copy link
Contributor

youknowriad commented Nov 30, 2017

Yes I think it's a duplicate of #3302 Most TinyMCE fields don't display properly because TinyMCE is not used the same way in Gutenberg compared to the classic Editor.

Using the same version for TinyMCE for Gutenberg and those fields (we're temporarily using the most recent TinyMCE for Gutenberg compared to Core's version) might improve the situatation here. But I still expect some TinyMCE metaboxes to be incompatible with Gutenberg and should be marked as such to fallback to the classic editor.

@maddisondesigns
Copy link
Author

So you're saying that because you've implement TinyMCE differently, this one field is going to force any use of ACF, PODS and CFS to revert back to the classic editor?

@youknowriad
Copy link
Contributor

I'm saying, most likely no since I suspect that using the same version of TinyMCE might fix these fields. But some metaboxes using the global TinyMCE and old selectors might break and we have two options for these:

  • Mark them as incompatible with Gutenberg and fallback to avoid breakage
  • Update them slightly (which probably means, changing some Javascript method calls and update selectors) to make them work with Gutenberg.

@maddisondesigns
Copy link
Author

Thanks for clarifying that

@BE-Webdesign BE-Webdesign added the [Feature] Meta Boxes A draggable box shown on the post editing screen label Dec 3, 2017
@danielbachhuber danielbachhuber added the [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Meta Boxes A draggable box shown on the post editing screen [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

5 participants