Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support placeholder text for Editable component #378

Closed
aduth opened this issue Apr 6, 2017 · 2 comments
Closed

Support placeholder text for Editable component #378

aduth opened this issue Apr 6, 2017 · 2 comments
Assignees
@ellatrix
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] High Used to indicate top priority items that need quick attention [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
May Week 2

Comments

@aduth
Copy link
Member

aduth commented Apr 6, 2017

See image block mockups at #310

image

In order to show the default caption text "Write caption…" we need to be able to support a placeholder prop to the <Editable /> component akin to the input and textarea attribute of the same name.
@aduth aduth added Good First Issue An issue that's suitable for someone looking to contribute for the first time Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take TinyMCE labels Apr 6, 2017
@aduth aduth mentioned this issue Apr 6, 2017
Merged
@ellatrix ellatrix self-assigned this Apr 14, 2017
@jasmussen jasmussen added this to the Prototype Parity milestone Apr 20, 2017
@jasmussen jasmussen changed the title Support placeholders for Editable component Support placeholder text for Editable component Apr 20, 2017
@jasmussen jasmussen mentioned this issue Apr 20, 2017
Closed
15 tasks
@BE-Webdesign
Copy link
Contributor

Being worked on in #475.

@mtias mtias modified the milestones: May Week 1, Prototype Parity May 1, 2017
@mtias mtias added [Priority] High Used to indicate top priority items that need quick attention [Feature] Blocks Overall functionality of blocks and removed Framework Issues related to broader framework topics, especially as it relates to javascript labels May 1, 2017
@jasmussen jasmussen modified the milestones: May Week 1, May Week 2 May 10, 2017
@ellatrix
Copy link
Member

Added with #756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] High Used to indicate top priority items that need quick attention [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
May Week 2
Development

No branches or pull requests
5 participants
@mtias @jasmussen @aduth @ellatrix @BE-Webdesign