Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons Block: Clicking inserter icon to add a button should use styling of an existing button in the list #37904

Closed
andrewserong opened this issue Jan 12, 2022 · 0 comments · Fixed by #37905
Assignees
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Jan 12, 2022

What problem does this address?

When you hit "enter" from within a Button block, the added button block uses the same styling as the existing button block, which makes it nice and easy to edit a list of similarly styled buttons. However, the inserter button displayed at the end of the Buttons block currently doesn't respect the styling of the existing buttons.

What is your proposed solution?

When you click the + icon at the end of a list of Button blocks to insert an additional Button, let's see about grabbing the styling / attributes of the last Button block in the list and applying that to the inserted block, consistent with the Enter key behaviour.

Here is a screengrab of the current behaviour when we hit "enter" to add a Button block, and when we click the inserter at the bottom of the Buttons block:

Kapture.2022-01-12.at.15.53.43.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
1 participant