Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Sidebar: Improve arrow key navigation and focus #39802

Open
getdave opened this issue Mar 28, 2022 · 5 comments
Open

Nav Sidebar: Improve arrow key navigation and focus #39802

getdave opened this issue Mar 28, 2022 · 5 comments
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Mar 28, 2022

When moving inside a navigation item with the Arrow keys, focus doesn't follow the visual order of the buttons. I can only focus "Move up" and "Move down" by focusing the "Options" button first, and then moving back with Left Arrow. Not sure what's happening there, but focus order and markup order aren't matching.

See #39290.

As suggested there let's improve the navigation using arrow keys.
@getdave getdave added [Type] Bug An existing feature does not function as intended [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a labels Mar 28, 2022
@getdave getdave mentioned this issue Mar 28, 2022
Merged
5 tasks
@tellthemachines tellthemachines added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Apr 1, 2022
@tellthemachines
Copy link
Contributor

As @talldan suggested here, we could also temporarily hide the movers until this problem is fixed. We shouldn't ship the navigation sidebar in 6.0 with pending a11y issues.

@talldan talldan mentioned this issue Apr 5, 2022
Merged
@talldan
Copy link
Contributor

talldan commented Apr 5, 2022

I'm getting a bit nervous about this with the release around the corner, so I've made a PR that hides the movers - #40039.

@getdave getdave changed the title Improve arrow key navigation and focus Nav Sidebar: Improve arrow key navigation and focus Apr 5, 2022
@getdave
Copy link
Contributor Author

getdave commented Apr 5, 2022

I'm getting a bit nervous about this with the release around the corner, so I've made a PR that hides the movers - #40039.

Apologies I've been sidetracked fixing bugs in the Nav block itself.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Oct 3, 2022
@getdave
Copy link
Contributor Author

getdave commented Oct 4, 2022

Still valid.

@Mamaduka Mamaduka removed the Needs Testing Needs further testing to be confirmed. label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Mamaduka @getdave @talldan @tellthemachines