-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Select: hide grouping controls for when selecting text only blocks #40063
Comments
Interesting idea! Why do we want to hide the controls when text blocks are selected? Grouping text blocks can be useful if there are paragraphs and headings that someone wants to highlight together: Or was it more about if text is only partially selected, then we should hide it 🤔 Apologies if the context is clearer from the 6.0 walkthrough, I didn't manage to catch it! 🙂 |
Thanks for clarifying! I see, yes, looks like we've got two slightly different use cases to look after:
Adding some kind of logic that hides the controls when there's a partial selection of text within heading / paragraph blocks sounds good to me 👍 |
Someone could argue that the block toolbar and block actions menu are more about handling blocks as whole.. This is the approach we will take regarding the |
I think I'm leaning slightly that way, too, since it can be difficult to predict intent just from the existence of a partial selection. |
Closing this out as two years on we don't have a way forward. |
What problem does this address?
When using multi-select, the block toolbar still displays the tooling to group/row/stack blocks:
multi.select.grouping.mov
This was found during the 6.0 walkthrough.
What is your proposed solution?
When using multi select with text only blocks (header, paragraph, etc), hide the controls for group/row/stack options:
The text was updated successfully, but these errors were encountered: