Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fonts API] enqueue programmatically fonts picked in block settings #40386

Closed
zaguiini opened this issue Apr 15, 2022 · 1 comment
Closed

[Fonts API] enqueue programmatically fonts picked in block settings #40386

zaguiini opened this issue Apr 15, 2022 · 1 comment

Comments

@zaguiini
Copy link
Member

zaguiini commented Apr 15, 2022 •
edited
Loading

What problem does this address?

Picking a programmatically registered font in the block settings does not enqueue it, unless it's been allow-listed in theme.json[settings][fontFamilies].

What is your proposed solution?

We need to introspect block settings on render and look for font families. Once a family is found, and that font is registered, enqueue it.

Blockers

We only want to work on this after #40362, so only a subset of programmatically registered webfonts show up in the block settings.
@zaguiini zaguiini added [Priority] High Used to indicate top priority items that need quick attention [Feature] Webfonts labels Apr 15, 2022
@zaguiini zaguiini mentioned this issue Apr 15, 2022
Closed
@mtias mtias mentioned this issue May 23, 2022
Open
17 tasks
@hellofromtonya hellofromtonya mentioned this issue Jun 1, 2022
Closed
5 tasks
@andrewserong andrewserong mentioned this issue Jun 10, 2022
Merged
@hellofromtonya hellofromtonya removed the [Priority] High Used to indicate top priority items that need quick attention label Jun 23, 2022
@hellofromtonya hellofromtonya changed the title Webfonts: enqueue programmatically webfonts picked in block settings [Fonts API] enqueue programmatically fonts picked in block settings Apr 6, 2023
@hellofromtonya
Copy link
Contributor

Hmm, I think this issue is not an issue after #40362 gets resolved.. Why? The intent is to populate typography pickers with only enqueued fonts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hellofromtonya @zaguiini