Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty toolbar element is visible when editing template parts in isolation #41047

Closed
carolinan opened this issue May 13, 2022 · 5 comments · Fixed by #46298
Closed

Empty toolbar element is visible when editing template parts in isolation #41047

carolinan opened this issue May 13, 2022 · 5 comments · Fixed by #46298
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Template Editing Mode Related to the template editor available in the Block Editor

Comments

@carolinan
Copy link
Contributor

Description

When you create a new template part or edit a template part in isolation, and reduce the browser window width,
there is an empty element with the class ".block-editor-block-contextual-toolbar" at the top of the editable area/ canvas, inside the dark grey border.

Because it is inside the dark grey border, it looks like it is in the editable area and the elements visible border is confusing.

In comparison, when editing a template in isolation in the template editor, this element is above the dark grey border.
When editing a template in the Site Editor, the element is above the canvas.

Step-by-step reproduction instructions

  1. Activate a block theme
  2. Go to the Site Editor and select a template part and choose "Edit". Or, create a new template part.
  3. Once in the template editor, reduce the browser window width.
  4. See that there is a border showing at the top of the editable area.

(In Twenty Twenty-two, using a dark header template part, it will show as a white field above the dark header)

Screenshots, screen recording, code snippet

Template part:
image

Template in template editor:
image

Template in Site Editor:
image

Environment info

6.0 RC 2.
With and without Gutenberg trunk
beta tester plugin

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

@carolinan carolinan added [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Block] Template Part Affects the Template Parts Block labels May 13, 2022
@carolinan
Copy link
Contributor Author

Perhaps instead of having the bottom border on block-editor-block-contextual-toolbar, perhaps on this screen, it could be added to the inner element that is only present on the page when the toolbar is populated?

@ramonjd
Copy link
Member

ramonjd commented Dec 5, 2022

This is even more obvious now in the site editor "view" canvas mode:

Screen Shot 2022-12-05 at 1 03 43 pm

only present on the page when the toolbar is populated?

What about hiding it where no blocks are selected? Trying that out here: #46298

@carolinan
Copy link
Contributor Author

@ramonjd If I understood the discussions in the PR correctly it was a partial fix, should this issue be reopened?

@ramonjd
Copy link
Member

ramonjd commented Dec 12, 2022

Thanks @carolinan Yeah it ended up targeting the site editor view mode only. I'll reopen.

Maybe #40450 will go some way to address this issue

@ramonjd ramonjd reopened this Dec 12, 2022
@carolinan
Copy link
Contributor Author

I can not reproduce this in 6.3 RC1.

@carolinan carolinan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Template Editing Mode Related to the template editor available in the Block Editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants