Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar ellipsis tooltip is confusing #4239

Closed
karmatosed opened this issue Jan 3, 2018 · 8 comments · Fixed by #6140 or #6162
Closed

Toolbar ellipsis tooltip is confusing #4239

karmatosed opened this issue Jan 3, 2018 · 8 comments · Fixed by #6140 or #6162
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@karmatosed
Copy link
Member

@ElectricFeet in testing had this to say:

While the tooltip on the block-hover-three-dots says "Open settings menu", clicking on it does not open a settings menu. It gives a menu, one of whose items is "Settings". This is confusing — the tooltip is not descriptive of what it does.

This is true, we should think of something better to say here.

@amandablum
Copy link

I think "block options" is a better solution here, agreeing with @ElectricFeet. This would also create some guidance on separating what is available in this ellipses vs available in block settings. Block Options implies it is specific to this block, which it is, and that it is different from settings, which it is.

@danieltj27
Copy link
Contributor

I agree with @amandablum - Block Options seems to make the most sense judging by what that menu actually provides the user.

@amandablum
Copy link

I think options vs settings could have larger implications in terms of gutenberg lexicon, as I think forward to teaching people the finer points of how to use Gutenberg and that there will be so many different places to affect things. In bringing functionality, we're also complicating. Options implies things to be done to this block. Settings implies things done to this block content. If we are justifying the two different panels (ellipses and block tab) then there should be a very clear delineation of which does what. for instance, if we added a "move block" option, that would go under options, not settings. Showing settings as part of options is a helpful way to lead people to the settings tab and establish the hierarchy of options vs settings. The tooltip can be "change block content settings" which makes the point even clearer. The only other option that I can see if clearly saying "Block settings" vs "Block Content Settings".

@ElectricFeet
Copy link
Contributor

Thanks to all for picking up on this. I'd be interested in what people think of my "bringing it all together" graphic:
redonemenus

Does this make sense?

@karmatosed
Copy link
Member Author

karmatosed commented Jan 15, 2018

I think we could just say settings over 'block settings'. Right now we're debating what the side should say.

@karmatosed karmatosed added the [Type] Copy Issues or PRs that need copy editing assistance label Mar 6, 2018
@afercia
Copy link
Contributor

afercia commented Apr 12, 2018

There are other occurrences of "advanced settings" that should be updated as well.

Specifically, the aria-label for the sidebar (2 occurrences) should match the new naming. This is important fo screen reader users so they know the sidebar is named "Block settings" and when using the related button in the menu they understand what it refers to.

Right now, I see the sidebar still identified with the old name:
<div class="edit-post-sidebar" role="region" aria-label="Editor advanced settings" tabindex="-1">

Also, I se a few occurrences in docs/design.md that should be updated as well. /cc @gziolo

Re-opening to avoid to open a new issue.

@afercia afercia reopened this Apr 12, 2018
@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Apr 12, 2018
abdullah1908 added a commit to abdullah1908/gutenberg that referenced this issue Apr 12, 2018
abdullah1908 added a commit to abdullah1908/gutenberg that referenced this issue Apr 12, 2018
@abdullah1908
Copy link
Contributor

abdullah1908 commented Apr 12, 2018

Hi @afercia @gziolo ,

Do you think, the section title should be changed from Advanced Settings to Block Settings?
https://github.com/WordPress/gutenberg/blob/master/docs/design.md#advanced-settings

Thanks

gziolo pushed a commit that referenced this issue Apr 13, 2018
* Change advance to block for issue #4239

* Change advanced to block for issue #4239
@gziolo gziolo reopened this Apr 13, 2018
@gziolo
Copy link
Member

gziolo commented Apr 13, 2018

It got auto-closed because of PR merged. We still need docs changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
7 participants