Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media & text block validation error from blocks in the pattern directory #42805

Closed
carolinan opened this issue Jul 29, 2022 · 1 comment · Fixed by #42816
Closed

Media & text block validation error from blocks in the pattern directory #42805

carolinan opened this issue Jul 29, 2022 · 1 comment · Fixed by #42816
Assignees
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

carolinan commented Jul 29, 2022

Description

Since #40806 there is a block validation error for media & text block created before the pull request was merged. But the errors are specifically for media & text blocks in the pattern directory, and I am not able to reproduce it with local blocks.

Step-by-step reproduction instructions

I used this method to test "local" blocks:

  1. Deactivate Gutenberg. Activate Twenty Twenty-Two.
  2. Using WordPress 6.0 or newer, go to either editor and add two media and text blocks:
    one with media on the left, and one to the right. Save.
  3. Activate Gutenberg trunk.
  4. Refresh the editor where you placed the blocks.

You should see errors for block patterns in the block pattern directory if you open the browser developer tools console, but not for any of the blocks that are placed in the editor.

Screenshots, screen recording, code snippet

See screenshots in the discussion on the pull request.

Environment info

WordPress 6.0.1
Gutenberg current trunk.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended [Block] Media & Text Affects the Media & Text Block labels Jul 29, 2022
@Mamaduka
Copy link
Member

I think this is the issue with deprecation(s). Maybe they're not correctly applied in some cases.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 29, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants