Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invalid navigation menu links #42908

Open
talldan opened this issue Aug 3, 2022 · 0 comments
Open

Improve invalid navigation menu links #42908

talldan opened this issue Aug 3, 2022 · 0 comments
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement.

Comments

@talldan
Copy link
Contributor

talldan commented Aug 3, 2022

What problem does this address?

When testing, I couldn't get the feature introduced in #31716 to work correctly.

These tooltips never seems to display:

They're supposed to show the text "This item has been deleted, or is a draft" or "This item is missing a link", which seems important. The problem is that the tooltips are anchored to React Fragments so won't ever be positioned, and that seems to have been the case since the introduction of the feature (you can see the tooltips never appear in the gifs in the PR).

It also doesn't consider a link to a post that has been deleted as invalid, only one that's currently in the trash.

Another problem is that if a link to a draft is present, the label isn't editable. This is something a user would want to do if they're in the process of launching a new page on their website. It seems like this was a late addition to the PR (#31716 (comment)), so probably wasn't tested fully.

Also note that there's a separate issue around this feature in that it can spawn a lot of individual HTTP requests (#42904).

What is your proposed solution?

I did see whether fixing the tooltip would be a quick thing, but IMO it doesn't look good given the way it overlaps the toolbar. It looks very cluttered:
Screen Shot 2022-08-03 at 1 49 50 pm

It might be better to move the more detailed status information into the LinkControl popover.

@talldan talldan added [Type] Enhancement A suggestion for improvement. [Block] Navigation Link Affects the Navigation Link Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Block] Navigation Affects the Navigation Block labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

1 participant