Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click required for inner block selection #43227

Closed
draganescu opened this issue Aug 15, 2022 · 6 comments
Closed

Double click required for inner block selection #43227

draganescu opened this issue Aug 15, 2022 · 6 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@draganescu
Copy link
Contributor

draganescu commented Aug 15, 2022

Description

While testing #42735 @jasmussen found the reason why you can't select the Page List child block unless you use the list view.

This is only the case when the mobile responsive feature is enabled, and it looks like the "responsive container" intercepts the click.

In #42735 this was somewhat fixed but now we need to double click the page list to select it. Still not the expected behavior.

Step-by-step reproduction instructions

Screenshots, screen recording, code snippet

cant select

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Aug 15, 2022
@scruffian
Copy link
Contributor

I think this was fixed in #42735

It requires a double click to select the child though, I'm not sure if that's expected?

@jasmussen
Copy link
Contributor

It requires a double click to select the child though, I'm not sure if that's expected?

I noticed this too, and I don't think this is to be expected. Do we actually have code in place to intercept a double click? It feels unintentional 🤔

@draganescu
Copy link
Contributor Author

It is unintentional. I'll change the Issue accordingly.

@draganescu draganescu changed the title Mobile responsive navigation prevents inner block selection Double click required for inner block selection Aug 23, 2022
@getdave
Copy link
Contributor

getdave commented Sep 8, 2022

Screen.Capture.on.2022-09-08.at.16-17-51.mp4

Testing this with Page List. I could click through with a single click. I'm not following the bug from the testing instructions.

I also tried converting Page List to links. I was still able to select all Navigation Link blocks with a single click.

@scruffian
Copy link
Contributor

It's still happening for me:

Sep-09-2022.13-25-41.mp4

@mrfoxtalbot
Copy link

I was retesting this with Version 14.2.0 and it appears to be solved now. I seem to be able to select the page list with a single click:

Screen.Capture.on.2022-09-30.at.14-58-55.mp4

Related: #42882

I am going to close this @draganescu, but please feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants