Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Block: Consider placing inner content in a physical direction #43625

Closed
t-hamano opened this issue Aug 26, 2022 · 0 comments · Fixed by #43663
Closed

Cover Block: Consider placing inner content in a physical direction #43625

t-hamano opened this issue Aug 26, 2022 · 0 comments · Fixed by #43663
Assignees
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Internationalization (i18n) Issues or PRs related to internationalization efforts

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

In #36237, there was a problem that the tooltip text shown by the matrix control of the cover block is the opposite of the physical arrangement in the RTL language. This is based on the fact that AlignmentMatrixControl flips dots left to right in the RTL language.

Therefore, in #43126, the AlignmentMatrixControl component was updated by adding direction:ltr so that the dots always indicate the physical direction, independent of the language direction. However, since the cover block is based on a logical arrangement using flex layout, a quick fix was added to maintain the original behavior.

But essentially, the matrix control should indicate a physical direction, so a change in language direction should not change the physical location of the inner content in the cover block.
(The current spec is that the placement flips left to right if the language direction changes.)

What is your proposed solution?

I propose to maintain the physical direction in the RTL language without reversing it.

@t-hamano t-hamano added Internationalization (i18n) Issues or PRs related to internationalization efforts [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Aug 26, 2022
@t-hamano t-hamano self-assigned this Aug 26, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2022
@t-hamano t-hamano changed the title Cover Block: Consider placing inner content in a physical direction. Cover Block: Consider placing inner content in a physical direction Aug 29, 2022
@t-hamano t-hamano removed the [Status] In Progress Tracking issues with work in progress label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
1 participant