Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation List View: Add an "edit" option #45442

Closed
scruffian opened this issue Nov 1, 2022 · 5 comments
Closed

Navigation List View: Add an "edit" option #45442

scruffian opened this issue Nov 1, 2022 · 5 comments
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

scruffian commented Nov 1, 2022

As outlined in #42257, we need to give users the option to edit Navigation Items.

Ideally this should be according to this design:
Screenshot 2022-11-01 at 11 31 35

If it's faster to do this in another way in order to get a prototype together, we should also consider that option.

@scruffian scruffian added the [Block] Navigation Affects the Navigation Block label Nov 1, 2022
@kathrynwp kathrynwp added the [Type] Enhancement A suggestion for improvement. label Nov 1, 2022
@georgeh georgeh self-assigned this Nov 3, 2022
@georgeh
Copy link
Contributor

georgeh commented Nov 3, 2022

I'm looking at the interactions shown in this video on #42257

I see 2 interactions in that video:

  1. Editing a Page List block should trigger the "Convert to Links" modal
  2. Editing another block should slide in an inspector panel for editing that block's attributes

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 6, 2022
@scruffian
Copy link
Contributor Author

This is covered by #45815 for now.

@georgeh
Copy link
Contributor

georgeh commented Nov 22, 2022

@getdave I'm reopening this one to focus on the convert-to-links modal

@georgeh georgeh reopened this Nov 22, 2022
@getdave
Copy link
Contributor

getdave commented Nov 22, 2022

to focus on the convert-to-links modal

Sounds good. Thanks 🙇 Any ideas yet on what specifically will you tackle and in what order?

@scruffian
Copy link
Contributor Author

scruffian commented Dec 1, 2022

I'm going to close this as the basic issue is done. If there's more work to do lets create a more specific issue. Thanks!

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants