Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Variation Picker doesn't support icons registered with the src attribute. #46372

Closed
gigitux opened this issue Dec 7, 2022 · 0 comments · Fixed by #46373
Closed

Block Variation Picker doesn't support icons registered with the src attribute. #46372

gigitux opened this issue Dec 7, 2022 · 0 comments · Fixed by #46373
Labels
[Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Type] Bug An existing feature does not function as intended

Comments

@gigitux
Copy link
Contributor

gigitux commented Dec 7, 2022

Description

The component BlockVariationPicker doesn't support icons with the src attribute.

Step-by-step reproduction instructions

  1. Create a Query Loop variation that has a declared icon with src (you can use this code).
  2. Add the Query Loop block.
  3. Click Start Blank.
  4. The block crashes.

Screenshots, screen recording, code snippet

Screen.Capture.on.2022-12-07.at.17-50-53.mp4

Environment info

  • WordPress 6.1
  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Type] Bug An existing feature does not function as intended [Feature] Block Variations Block variations, including introducing new variations and variations as a feature labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants