Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Scroll bars appear when a variation panel is hovered, on certain browser and resolution #46506

Closed
fushar opened this issue Dec 13, 2022 · 3 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@fushar
Copy link

fushar commented Dec 13, 2022

Description

In the Global Styles sidebar, scroll bars are displayed when a variation panel is hovered. As far as I observe, this only happens in this situation:

  1. Browser is Firefox
  2. External monitor is used

(see version details below)

I believe this is the exact same issue as #44796. It was fixed on 14.4.0 via #44823. Interestingly, this issue only occurs after 14.4.0 -- it didn't happen before that. So it looks like the fix (#44823) solved the previous issue but introduced another issue (this issue).

cc: @t-hamano @mtias

Step-by-step reproduction instructions

  1. Activate a block theme with style variations (e.g. TT3)
  2. Open the Global Styles sidebar, and click Browse Styles.
  3. Observe that vertical and horizontal scroll bars appear momentarily when you mouse over or focus on a variation preview panel.

Screenshots, screen recording, code snippet

Environment info

  • WordPress 6.1.1
  • Gutenberg 14.7.1
  • Firefox 107.0.1 (64-bit)
  • macOS Monterey 12.1 (M1 Pro)
  • LG 27UP850-W Monitor 27-Inch IPS 4K UHD VESA HDR400 USB-C with the following settings:

image

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@dsas
Copy link
Contributor

dsas commented Dec 13, 2022

Oddly, I can reproduce that in Gutenberg 14.7.1 but I can't reproduce it in Gutenberg trunk (6a54882).

@kathrynwp kathrynwp added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Regression Related to a regression in the latest release labels Dec 13, 2022
@t-hamano
Copy link
Contributor

t-hamano commented Dec 14, 2022

@dsas
I got the same result. This problem occurs in Firefox, but not in Chrome.

  • Released Gutenberg Plugin version 14.7.1: Reproduced
  • Released Gutenberg Plugin version 14.7.2: Reproduced
  • Use the plugin built by build:plugin-zip in the latest trunk: NOT reproduced

I think Gutenberg plugin version 14.7.2 and trunk are almost identical, so I don't know why this difference occurs.
Sorry, this one was my misunderstanding.

Just to be sure, we will retest with Gutenberg Plugin 14.8, which will be released in two weeks, and I think we can close this issue if the problem does not appear.

@t-hamano
Copy link
Contributor

I have identified a PR that has resolved this issue.
This issue appears to have been unintentionally resolved in #44770.

44770

The #44770 is included in the unreleased Gutenberg version 14.8.

@fushar
I would like to close this issue as resolved. If you reproduce the problem in the version 14.8 to be released, I would be glad to receive your comments.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

4 participants