-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duotone and social icons are hard coded as hex values and this is not good when switching style variations #46547
Comments
Thanks for raising this, @anarieldesign It would be helpful if there were more context available |
This would be solved by #42870, at least the duotone part, but I haven't had the time to work on it recently |
I've noticed the issue with social icons. I'll add some visuals to help illustrate the issue. This example uses Twenty Twenty-three, but this is not a theme-specific issue. Let's say you wanted to have social icons that match the theme colours. So you chose the Save the page and change the style to the You'd expect the colours of the social icons to change to the theme colours in The colour setting in the editor says what you expect, but the colours of the icons are stuck with the ones from the If you re-select the colours again in the editor, it changes the colour, but it shouldn't require you to do so. |
@iamtakashi Thanks for walking me through the issue. Great illustrations. |
The social icons color is a longstanding issue: |
@ndiego solved this problem in his great plugin. Maybe that's a clue? |
This comment was marked as resolved.
This comment was marked as resolved.
@getdave Thanks for looking into this issue.
I'm not following this bit. I'd expect an element with
In this example, when you switch to the Pitch style variation, the icon background should change to However, the icon and icon background colours remain to be the colours from the default, |
Thanks for the shoutout @gyurmey2. I'll take a look at this next week and see if a similar solution could be applied. |
@iamtakashi I follow this now. Sorry for confusing things. I will hide my comments. |
Thank you. |
Reopening since #51020 solved the social icons part, but the duotone part is still relevant. |
Theme is using predefined color palette. For example primary or accent slug. When I switch to different style variations, block patterns are changing the colors, as I'm using slugs for the colors. But duotone and social icons are hard coded hex colors ("duotone":["#211F1D","#E61D3E"]) and they are always in the same color. I definitely think they should not be hard coded as hex values, as that reduces the creativity of patterns. For example in our latest theme I needed to choose black color for the social icons as if I choose the accent color and switch to other style variation it will not change to the accent color of that style variation. As it's hard coded hex color it always stay in that color and I think this is not good.
Hope this makes sense.
The text was updated successfully, but these errors were encountered: