Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear Submit and Cancel buttons to Link UI #46593

Closed
getdave opened this issue Dec 15, 2022 · 2 comments · Fixed by #46933
Closed

Add clear Submit and Cancel buttons to Link UI #46593

getdave opened this issue Dec 15, 2022 · 2 comments · Fixed by #46933
Assignees
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@getdave
Copy link
Contributor

getdave commented Dec 15, 2022

Currently there a number of problems in the Link UI which result from a lack of clarity about when a user intends to "submit" changes to a given link.

A classic example is the "Open in new tab" toggle. Should toggling this close the UI and update the link? Or should it merely toggle the switch and wait for you to re-submit the entire link.

It would be a lot clearer and unambiguous if we simply introduced Submit and Cancel buttons. Here's a nice example of Evernote:

Screen Shot 2022-12-15 at 21 23 46 (1)

By adding these we can remove an entire class of bugs whilst at the same time making the UX a lot clearer for users.

@getdave getdave added Needs Design Feedback Needs general design feedback. [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Dec 15, 2022
@getdave getdave self-assigned this Dec 15, 2022
@getdave
Copy link
Contributor Author

getdave commented Jan 5, 2023

Note: the dual submit/cancel buttons should probably only be present once the initial link has been created and the user has hit "Edit".

@jasmussen
Copy link
Contributor

Just noting that there's a fair bit of good design feedback on the PR in question, so removing the label from here: #46933

@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants