Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for opacity style property to theme.json #46755

Open
mikachan opened this issue Dec 23, 2022 · 7 comments
Open

Add support for opacity style property to theme.json #46755

mikachan opened this issue Dec 23, 2022 · 7 comments
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@mikachan
Copy link
Member

What problem does this address?

Users are not currently able to set the opacity of an element just from the theme.json file or Global Styles. This is a common design choice for things such as button pseudo states.

What is your proposed solution?

Add support for the opacity property.

@mikachan mikachan added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Dec 23, 2022
@npneeraj
Copy link

@mikachan please assign me this issue / feature . I can contribute to add/do the above following task.

@mikachan
Copy link
Member Author

Done, thank you! ✨ I'm happy to review a PR when you're ready.

@npneeraj
Copy link

npneeraj commented Jan 4, 2023

@mikachan I have read the docs and the theme.json file but I am confused where to add the opacity property since the theme.json seems to be of declaration file. I could not find the CSS file. Please share some hints or relevant resources that could be of any help, since I am new to OpenSource World.

@mikachan
Copy link
Member Author

mikachan commented Jan 5, 2023

Hi @npneeraj. Here are some links that may help to explain the theme.json file further:

This issue is for adding support for the opacity property to the theme.json file so it can be used to style blocks.

Here is a similar PR for adding support for box-shadow: #41972

If you prefer, I can start a PR for this, and I'm happy for you to help by contributing code or reviewing it.

@mikachan mikachan changed the title Add opacity style property to theme.json Add support for opacity style property to theme.json Jan 5, 2023
@npneeraj
Copy link

npneeraj commented Jan 6, 2023

Hi @mikachan . Thanks for sharing the above resources.
Please start a PR for this for future code contributions and code-reviews.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 27, 2023
@hanneslsm
Copy link

hanneslsm commented Oct 27, 2023

Hey @npneeraj – any progress on this?
This is becoming important since the File block has a hard coded opacity value on hover which can't be overwritten via the theme.json yet:

@npneeraj
Copy link

Hi @hanneslsm - sorry to say, it appears to be a dead-end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants