Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomly duplicating design tools #47293

Closed
annezazu opened this issue Jan 19, 2023 · 14 comments · Fixed by #47459
Closed

Randomly duplicating design tools #47293

annezazu opened this issue Jan 19, 2023 · 14 comments · Fixed by #47459
Assignees
@t-hamano
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Jan 19, 2023 •
edited
Loading

Description

When selecting different blocks in the Site Editor using Gutenberg 15.0 (and all experiments turned off), I found by clicking more than once on a block, I can make the design tools duplicate in the sidebar. From what I can tell, I think it's happening when you click on a block of one type (featured image) and then click on another of the same block (featured image) but I'm not quite sure. cc @ndiego in case you have time to help test. Trying to share this ASAP to get more eyes.

Step-by-step reproduction instructions

  1. Use Gutenberg 15.0.
  2. Open the Site Editor under Appearance > Editor.
  3. Click on a featured image block in a query loop with the block settings open.
  4. Click on a different featured image block in the query loop. Notice design tools randomly double.

Screenshots, screen recording, code snippet

duplicating.deign.tools.mov

Environment info

  • WP 6.1.1
  • GB 15.0
  • TT3
  • MacOS
  • Chrome Version 108.0.5359.124

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jan 19, 2023
@annezazu annezazu changed the title Duplicating design tools Randomly duplicating design tools Jan 19, 2023
@annezazu
Copy link
Contributor Author

I made a replay.io recording replicating this: https://app.replay.io/recording/replication-for-randomly-duplicating-design-tools-47293--e4d4d1a6-8fe2-49ea-bc96-dfb31417f2e1 This gives access to my specific environment where this can be replicated to save time and see what's going on.

If a developer is able to dig into this and wants access, please say so here and I will give you access to replay.io to dig in.

@annezazu
Copy link
Contributor Author

Really wild stuff is happening 😓 the more I click around:

Screen Shot 2023-01-19 at 8 53 05 AM

@ndiego
Copy link
Member

ndiego commented Jan 19, 2023

I believe this might be an issue related to Slot/Fill? Either way, I am able to confirm in the Site Editor with Gutenberg trunk.

site-editor-issue

@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Jan 19, 2023
@ironprogrammer
Copy link
Contributor

+1 on reproducing this issue.

Environment

  • Hardware: MacBook Pro Apple M1 Pro
  • OS: macOS 12.6.2
  • Browser: Safari 16.2, Google Chrome 109.0.5414.87
  • Server: nginx/1.23.3
  • PHP: 7.4.33
  • WordPress: 6.1.1
  • Theme: twentytwentythree v1.0
  • Active Plugins:
    • gutenberg v15.0.0

Issue 47293 Repro

@aaronrobertshaw
Copy link
Contributor

This might be related to an issue I raised last week: #47101 which was fixed in via #47110.

@t-hamano
Copy link
Contributor

t-hamano commented Jan 20, 2023 •
edited
Loading

As @aaronrobertshaw said, I believe this issue was fixed in #47110. I have submitted a similar #47135. But this fix will be part of Gutenberg 15.1, which has not yet been released.

@annezazu
Copy link
Contributor Author

Can we release a point release for GB 15.0 to address this? The site editor felt unusable IMO with this currently in place.

@t-hamano
Copy link
Contributor

I too agree with the point release. Who should we mentions this to?

@tellthemachines
Copy link
Contributor

tellthemachines commented Jan 20, 2023 •
edited
Loading

I can still reproduce this on latest trunk, when clicking around inside the Post Template block. Once it's happened, then any other block on the page shows duplicate controls, but I could only trigger it within Post Template.

The other thing I'm noticing is that only Color and Typography-related controls are affected.

Screenshot 2023-01-20 at 11 40 02 am

@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.2 Editor Tasks Jan 20, 2023
@t-hamano
Copy link
Contributor

I was also able to reproduce it. Somehow, in my environment, it seems to be more likely to occur by clicking on the Post Excerpt Block in the query loop. In addition to 47110, I would like to find out what we need to fix.

9805daa587031ac0f2c5c2dbac98156e.mp4

@franzaurus
Copy link
Contributor

I'm also able to reproduce this on my machine, and made the replay.io recording in my test environment here:
https://app.replay.io/recording/replication-for-randomly-duplicating-design-tools-47293-on-windows--b06eec00-46a8-4e19-aa70-19b5149b12a4

In my case, the duplication was triggered by any blocks under the Post Template.

Environment

  • WP 6.1.1
  • Windows 11
  • Firefox 108.0.2
  • TT3
  • Gutenberg 15.0

Mcv345aop

@t-hamano t-hamano mentioned this issue Jan 21, 2023
Closed
@t-hamano
Copy link
Contributor

I believe #47331 will solve this problem.

@t-hamano t-hamano self-assigned this Jan 21, 2023
@annezazu
Copy link
Contributor Author

Asked in core editor to see if we can get some movement and help: https://wordpress.slack.com/archives/C02QB2JS7/p1674356272740079

@ndiego ndiego moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.2 Editor Tasks Jan 24, 2023
@aaronrobertshaw
Copy link
Contributor

It might be worth noting that to reproduce this on trunk, you need to select a block within the Post Template other than the first post. The following steps illustrate the bug for me:

  1. Open the Site Editor and edit a template with a query block
  2. In the list view, navigate to and select the query block's inner post template block
  3. Within the Post Template block, click the read more link for a post other than the first one.
  4. Note the duplicate controls in both the block toolbar and the inspector controls sidebar

@ndiego ndiego mentioned this issue Jan 25, 2023
Closed
@t-hamano t-hamano mentioned this issue Jan 26, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.2 Editor Tasks Jan 26, 2023
@ndiego ndiego moved this from 🔎 Needs Review to ✅ Done in WordPress 6.2 Editor Tasks Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.2 Editor Tasks
Status: ✅ Done
Milestone
No milestone
7 participants
@ironprogrammer @ndiego @tellthemachines @annezazu @t-hamano @aaronrobertshaw @franzaurus