Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow social link block movers based on layout orientation #48451

Closed
richtabor opened this issue Feb 25, 2023 · 0 comments · Fixed by #48452
Closed

Allow social link block movers based on layout orientation #48451

richtabor opened this issue Feb 25, 2023 · 0 comments · Fixed by #48452
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Layout Layout block support, its UI controls, and style output. [Type] Regression Related to a regression in the latest release

Comments

@richtabor
Copy link
Member

richtabor commented Feb 25, 2023

Description

Now that the social links block supports layout orientation — which allows for horizontal and vertical layouts — the child blocks' block movers need to adapt based on that orientation as well.

Currently, when you select a social link the block movers are always vertical arrows. The "up" arrow moves the block to the left, and the "down" arrow moves the block to the right.

We had this working properly previously, though I'm thinking the regression occurred with the introduction of layout controls for the parent block.

Step-by-step reproduction instructions

  1. Add a Social Links block.
  2. Add at least two links within the block.
  3. Select a link, see up and down movers that move it left and right.

Screenshots, screen recording, code snippet

Current (vertical block movers, although they move the social links left or right):

CleanShot 2023-02-24 at 19 14 50

Suggested (movers based on layout orientation):

CleanShot.2023-02-24.at.18.50.06.mp4

Environment info

  • WordPress Beta 3
  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@richtabor richtabor added [Type] Regression Related to a regression in the latest release [Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Layout Layout block support, its UI controls, and style output. labels Feb 25, 2023
@richtabor richtabor changed the title Allow social link block movers to be based on layout orientation Allow social link block movers based on layout orientation Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Layout Layout block support, its UI controls, and style output. [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant