Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced settings being mistaken for a heading #4871

Closed
karmatosed opened this issue Feb 5, 2018 · 8 comments
Closed

Advanced settings being mistaken for a heading #4871

karmatosed opened this issue Feb 5, 2018 · 8 comments
Labels
[Feature] Blocks Overall functionality of blocks

Comments

@karmatosed
Copy link
Member

This was reported from usability testing:

(Incidentally, some did click on a block’s vertical three dots to open the dropdown, but they were much more interested in block transformations and generally didn’t click “Show Advanced Settings.” My colleague Jen has a guess as to why that was happening: The :focus state stylings on the text “Show Advanced Settings” makes it look at first glance like a heading for the menu items that appear beneath it, rather than something that can itself be clicked.)

Our users took a while to discover that blocks had advanced settings in the right-hand panel—and once they discovered it for one block, most didn’t think to revisit that panel for other blocks without some prompting by us.

https://design.oit.ncsu.edu/2018/02/02/gutenberg-testing/

2018-02-05 at 11 35

As you can see it would be easy to mistake.

@karmatosed karmatosed added the [Feature] Blocks Overall functionality of blocks label Feb 5, 2018
@melchoyce
Copy link
Contributor

Any thought to a shortcut to flip over to Advanced Settings? I keep finding myself annoyed every time I have to go over and click on "Block" in the sidebar.

@karmatosed
Copy link
Member Author

karmatosed commented Feb 17, 2018

Any thought to a shortcut to flip over to Advanced Settings? I keep finding myself annoyed every time I have to go over and click on "Block" in the sidebar.

An interesting idea. There isn't, but I wouldn't be against one. Want to rustle up an issue @melchoyce and we can explore there?

@karmatosed karmatosed added the Needs Design Needs design efforts. label Mar 6, 2018
@karmatosed karmatosed assigned karmatosed and unassigned karmatosed Mar 7, 2018
@mtias
Copy link
Member

mtias commented Mar 7, 2018

The "add shortcuts to menu items" issue covers shortcuts for all these.

@karmatosed
Copy link
Member Author

To solve the issue reported by the user, let's considering un-focusing the first item. This will need a workaround to suit accessibility, possibly with a hidden item. cc @afercia to work through this as we need to balance out this as it's catching users.

@karmatosed karmatosed removed the Needs Design Needs design efforts. label Mar 7, 2018
@mtias
Copy link
Member

mtias commented Mar 7, 2018

Note: there are various other issue with the autofocusing (including the table of contents popover jumping to the headings). Ideally the implementation is one that moves focus to the popover (and keeps it there when you tab through) but doesn't focus the initial item.

@ZebulanStanphill
Copy link
Member

The discoverability of the block inspector should be improved thanks to #5882, and the focus style of the "More Options" menu is now a dotted outline rather a solid one like in the picture in the main post of this issue. Additionally, clicking on the "More Options" button does not automatically focus "Show Advanced Settings", so it should not be confused for a heading anymore.

Is it safe to consider this issue fixed?

@karmatosed
Copy link
Member Author

@SuperGeniusZeb no that doesn't solve the issue here.

@karmatosed
Copy link
Member Author

Let's focus this over on #5595 for now and close. The focus is the key to resolving this fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Development

No branches or pull requests

4 participants