Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot press "Enter" or "Return" to add a social link #49764

Closed
richtabor opened this issue Apr 12, 2023 · 1 comment · Fixed by #50158
Closed

Cannot press "Enter" or "Return" to add a social link #49764

richtabor opened this issue Apr 12, 2023 · 1 comment · Fixed by #50158
Assignees
@Mamaduka
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

In the existing LinkControl UI, I can add a URL, then press "Enter" and it is applied. But when adding social links, that flow no longer works—you are required to tab + enter, or manually press the arrow icon.

As an aside (which would resolve this as well), this could probably use the LinkControl component (#49091). Perhaps there's a prop to only allow custom URLs.

CleanShot.2023-04-12.at.11.36.20.mp4
@richtabor richtabor added [Type] Bug An existing feature does not function as intended [Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Apr 12, 2023
@richtabor richtabor changed the title Cannot press "Enter" to add a social link Cannot press "Enter" or "Return" to add a social link Apr 12, 2023
@Mamaduka
Copy link
Member

It's probably a regression after #40906.

@Mamaduka Mamaduka mentioned this issue Apr 28, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 28, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

URLInput: Update the 'ENTER' key down event handler WordPress/gutenberg
3 participants
@Mamaduka @richtabor @priethor