Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the REST API route from navigation-fallbacks to navigation-fallback #49997

Closed
getdave opened this issue Apr 21, 2023 · 0 comments · Fixed by #50044
Closed

Change the REST API route from navigation-fallbacks to navigation-fallback #49997

getdave opened this issue Apr 21, 2023 · 0 comments · Fixed by #50044
Assignees
@getdave
Labels
REST API Interaction Related to REST API

Comments

@getdave
Copy link
Contributor

getdave commented Apr 21, 2023

In #48698 we added a new endpoint navigation-fallbacks (plural). We should rename to navigation-fallback singular as it's not a collection.

Sorry, if it's not too much trouble can we change the REST API route from navigation-fallbacks to navigation-fallback in a follow-up PR? I keep reading the endpoint as returning a collection, when it's in fact an item endpoint.

Originally posted by @TimothyBJacobs in #48698 (comment)
@getdave getdave added the REST API Interaction Related to REST API label Apr 21, 2023
@getdave getdave self-assigned this Apr 21, 2023
@getdave getdave changed the title Sorry, if it's not too much trouble can we change the REST API route from navigation-fallbacks to navigation-fallback in a follow-up PR? I keep reading the endpoint as returning a collection, when it's in fact an item endpoint. Change the REST API route from navigation-fallbacks to navigation-fallback Apr 21, 2023
This was referenced Apr 21, 2023
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 24, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
REST API Interaction Related to REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace fallbacks to fallback (singular) in Nav fallback REST endpoint WordPress/gutenberg
2 participants
@getdave @priethor