Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL dialog: The cancel/apply/settings dialog appears even if you search inside a page link and don't find a page. #50162

Closed
jasmussen opened this issue Apr 28, 2023 · 1 comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)

Comments

@jasmussen
Copy link
Contributor

jasmussen commented Apr 28, 2023

Related to #49091. The trio of buttons for Settings, Cancel and Apply were recently added to the URL dialog. They make less sense when you search:

Screenshot 2023-04-28 at 12 08 14

Extracting from #49091 (comment):

If a link has already been created and submitted, what is the state when you click on that link again?

It should open this state where you can edit or remove the link, Clicking edit takes you back to the original state, pressing esc or input blur should show token again. "Add" action would change to "Save" (or adjust) if you're editing rather than adding.

image

Here's the full flow shown:

navigation.mp4

See the full flows in this comment.

@jasmussen jasmussen converted this from a draft issue Apr 28, 2023
@jasmussen jasmussen added Needs Dev Ready for, and needs developer efforts [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Apr 28, 2023
@jasmussen jasmussen moved this from Needs issue to Needs dev in 6.3 Design Apr 28, 2023
@scruffian
Copy link
Contributor

With the changes to link control I think we can close this now.

@apeatling apeatling moved this from Needs dev to Done in 6.3 Design Jun 27, 2023
@priethor priethor removed the Needs Dev Ready for, and needs developer efforts label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting)
Projects
Status: Done
Development

No branches or pull requests

3 participants