Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set link text at creation time for Navigation links #50179

Closed
getdave opened this issue Apr 28, 2023 · 6 comments
Closed

Add ability to set link text at creation time for Navigation links #50179

getdave opened this issue Apr 28, 2023 · 6 comments
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Needs design efforts.

Comments

@getdave
Copy link
Contributor

getdave commented Apr 28, 2023

The Link UI affords the ability to set the link text (text not the URL) directly from the popover. However in recent times this has been moved into the link "settings drawer" meaning it is not immediately visible when creating a link.

This causes issues for the Navigation block when adding links into a menu.

We need to fix this to improve the flows.

When adding a link it should be possible to set both the link URL and the link text during the initial creation phase. This will involve moving the text control out of the settings drawer.

@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Apr 28, 2023
@richtabor richtabor added the Needs Design Needs design efforts. label Apr 28, 2023
@richtabor
Copy link
Member

The current flow requires you to type a URL, apply it, then select the text and change it. Adding the text label alongside the link will make adding a link a more unified experience.

Current:

CleanShot.2023-04-28.at.16.33.14.mp4

@jasmussen
Copy link
Contributor

This is URL dialog relevant, not just navigation relevant, correct? CC: @SaxonF as I think he's dabbled with that interface as well.

@SaxonF
Copy link
Contributor

SaxonF commented May 1, 2023

The video in the link ui overview issue should cover this

@richtabor
Copy link
Member

richtabor commented May 3, 2023

This is URL dialog relevant, not just navigation relevant, correct?

I don't know that it's necessary in every context, but perhaps. I don't want to make links unnecessarily complicated if it's not necessary (adding the label wholesale).

In the case of adding a link to text, you have the text already there at least. In the Navigation block flow, you add a link without existing text - so the label uses the link instead, which is almost always going to be edited next; it's basically incomplete.

@getdave
Copy link
Contributor Author

getdave commented May 4, 2023

I understand the original motivation for hiding the link text was to remove clutter from the UI.

In this specific case however, I agree with @richtabor that the flow for adding links requires that we can set link text at point of link creation. The flow of

  • create link
  • click into canvas
  • edit text

...feels clunky. It would be much more fluid and natural if we could do the above in a single flow.

@richtabor
Copy link
Member

I'm going to close this in lieu of #50890, which details the link edit state holistically (including link and text fields on edit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Needs Design Needs design efforts.
Projects
None yet
Development

No branches or pull requests

4 participants