-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details view → Styles #50429
Comments
CC: @WordPress/gutenberg-design |
Also consider referring to the work on revisions: #50089 |
I think I saw a PR related to this recently #50329 Is this already fixed (I mean the menu item hidden when there's no style variations) |
In my flurry to create issues I wasn't able to properly test. But if there is, we still need the "Styles" item, to at minimum surface a deep link to the global styles panel. |
That's right. In trunk, if the theme does not offer style variations, then the Styles nav item is no longer available, per #50329: I think we should keep the Styles item and have the "Styles" action open the Edit view, with the Global Styles panel open (for now). And follow up with design explorations into adding the variations, revisions, and style book as navigation items within the Styles panel. Related: #50393 |
And perhaps consider labeling them "Theme variations", as they're within the Styles panel. |
cc @ntsekouras |
+1 on always showing Styles regardless of whether there are variations. Navigation becomes unpredictable otherwise. |
Re-opening as I've seen it suggested to include a deep link to the Style Book in this panel. |
This comment was marked as outdated.
This comment was marked as outdated.
We're working on it. If you'd prefer to tackle that in a separate issue I suppose it would be fine. |
It doesn't really matter. We can keep track of it here. |
Haha I just saw it's tracked in #50379 so we can close :D |
Btw it would be nice to be able to drill down into each style and see what settings these are made up of. It gives a deeper understanding of how each style is created. If we take this even further then each setting for a style could have an on/off toggle switch so the user can create a custom version of a style by turning off specific settings. By doing so creating another version of the style. |
Re-opening as we missed a detail here – access to style revisions. It can share the same design we've worked on for other panels, positioned at the bottom of the panel, just above the save button. I'll update the OP to include this task. |
Just double-checking, is the revisions item in the screenshot in this issue ready for dev now? I see there's also been some discussion over in #50924 about de-emphasising style variations, so wasn't sure which would be a good next task to pick up to help close out this issue. |
Yep, the design should be ready to go Andrew, thanks for asking. I've updated the labels. |
I have a PR open to explore adding in the Revisions button over in #51149 |
The Design → Styles view serves three purposes:
Variations
If the theme does not offer style variations, then the view becomes rather empty and incongruent:
We should improve this in a way that lets us keep the deep link to the global styles panel. A couple of ideas for what we could do:
Any style variations for your theme will show up here. For now you can click the edit button to edit style properties.
Styles
navigation item #50573Style book
Revisions
For access to revisions, we can use the same design as other panels, positioned directly above the save button:
It would be nice to load the revisions UI into the sidebar itself, but in the short term it may be necessary to deep link to the revisions panel in the full-screen editor.
The text was updated successfully, but these errors were encountered: