Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation on Browse Mode: Make navigations in the list selectable. #50579

Closed
scruffian opened this issue May 12, 2023 · 5 comments
Closed

Navigation on Browse Mode: Make navigations in the list selectable. #50579

scruffian opened this issue May 12, 2023 · 5 comments
Assignees
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

scruffian commented May 12, 2023

What problem does this address?

Following on from #50578, each of the navigations in the list should be selectable.

When users select a navigation from the list, update the navigation list view in the global sidebar to show the selected navigation, and show only that navigation menu in the preview. Also update the URL so that each navigation has its own direct URL and users can navigate the UI with URL history. This is unnecessary in the case where users have only one navigation.

Screenshot 2023-05-17 at 15 29 26
@draganescu
Copy link
Contributor

Now that this sidebar is a drill down sidebar can we avoid horizontal scroll bars caused by expanding deeply nested trees by navigating navigation menus using drill down as well @jasmussen ?

@jasmussen
Copy link
Contributor

Now that this sidebar is a drill down sidebar can we avoid horizontal scroll bars caused by expanding deeply nested trees by navigating navigation menus using drill down as well @jasmussen ?

As a hub for both light-weight editing and content access, the drilldowns are a way to pick an individualpage to see just that, then edit or configure it if you like.

For just a simple menu of pages, I like to think that we'd avoid deep nesting. As discussed, only simple menus should be editable right there on the left. Any menu that is "complex" (a heuristic we can work out together) you only see the name of the menu, but you edit the menu in the fullscreen editor. We can simply decide that menus with dropdowns are "complex". What do you think?

@draganescu
Copy link
Contributor

draganescu commented May 15, 2023

We can simply decide that menus with dropdowns are "complex". What do you think?

We can definitely try this. It depends on how well we manage to achieve the edit in isolation thing. If that turns our great, yes this could be a way. But I suspect people will want to add submenus in an initially simple menu. If I have

Home | Services | Contact

and then I want pages for each service and a service is made of sub items, I may want to do it right there:

Home | Services | Contact
           | Web design 
           | SEO
           | Fiddling with copy
           | Building megamenus

if we decide "menus with submenus are complex", then if the user has a simple menu open in the sidebar and they use the Plus to add, should they also be allowed to add nested items directly or do we do that in detail view alone?

@jasmussen
Copy link
Contributor

If editing on the left works well enough for 1 level submenus, seems fine.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a and removed [Block] Navigation Affects the Navigation Block labels May 16, 2023
@getdave getdave self-assigned this May 22, 2023
@getdave
Copy link
Contributor

getdave commented Jun 16, 2023

This is ✅

@getdave getdave closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Navigation in Site View Navigation section in the Site Editor when in Site View, offering a way to manage Navigation Menus a [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants