-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover Block: Fixed Background Does Not Work on Mobile #50669
Comments
@draganescu I asked here (Automattic/wp-calypso#76885) but to complete the loop is there any update here? |
Hi there! This issue does not appear to be worked on yet. Are you planning to try a PR - I think I inferred that from the other issue? |
Hi @draganescu thank you for getting back to me. We are waiting to see if our client is interested in us submitting a PR or wants us to build our own new component in their thee. However for transparency and anyone else looking into this ticket, from our research and the other ticket, here are some findings: The main issue is because Apple have decided to not support background-attachment; on iOS for iPhone and iPad, we believe this is because of performance issues caused by this attribute. The required behaviour is not impossible as you can see it on this codepen: https://codepen.io/Everybodyknows/pen/abbyLOZ However the build of this codepen is a completely different structure to the Guttenberg component in question. There are a couple of ways we could create this behaviour that works across those platforms.
So we think there is no simple CSS hack to trick we can do to fix the existing component, if we want to solve this we believe the component will need to be built in a different way. For now we are waiting to hear from our client, personally based on the effort involved to fix it vs customer impact we don't think it will go ahead however if it does I will let you know. |
Thanks for the awesome in depth description @robinglen 🙇🏻 I added the blocked label since I think this can be fixed only when the rule will become supported. |
@draganescu I've also linked this report Automattic/wp-calypso#95234, but aside from the fixed background that's not working, we also seem to experience a Zoomed-in view. A bit of a 2 in 1 issue. I reported the Zoom separately here first but decided to close it in favor of the one above. Is there a way to better organize these? |
@Robertght I don't think there is a better way. I would not keep duplicate issues anywhere and if they're 100% caused by the same problem (the zoom and the blank) then just keep one, augment the content and close the other. I wonder if we should try maybe a color fix or something... |
Description
Originally reported in Automattic/wp-calypso#76885
Quick summary
When the fixed background option of the cover block is enabled, it works on all platforms except mobile Safari.
It might be related to this previous issue: Automattic/wp-calypso#57390
Steps to reproduce
What actually happened
The background moves with the rest of the page.
Impact
All
Logs or notes
Summary
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Mobile
mobile.mov
Desktop
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: