Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Picker: Refine, show font preview, and load only active fonts from library #51151

Open
jasmussen opened this issue Jun 1, 2023 · 5 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Font Library [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

Extracted from #45271.

The font picker will show fonts that are registered in theme.json. As detailed in #45271, that means fonts added to your library which are active. The font picker can look like this:

Selecting fonts in Post Editor

The above design is an enhancement that focuses on showing a preview of the font itself, inline in the picker. But this design should not block either the webfonts API from landing, nor the font manager. The existing picker can work fine in the same system:

existing picker
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jun 1, 2023
@mtias
Copy link
Member

mtias commented Aug 2, 2023

Is this being handled as part of the Fonts UI work?

@jasmussen
Copy link
Contributor Author

Initially that was my instinct, but in order to separate concerns I split it out. Happy to consolidate again, though?

@mtias
Copy link
Member

mtias commented Aug 3, 2023

It's ok to have it split as long as we don't lose track of it!

@jasmussen
Copy link
Contributor Author

Right! @mikachan is #52698 a good tracking issue to include this one on? Or is there a better one?

@mikachan
Copy link
Member

mikachan commented Aug 3, 2023

Yeah, I think #52698 would be a good fit for this. I think it fits into the scope of that issue and I don't think there are any other, better tracking issues 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Font Library [Feature] UI Components Impacts or related to the UI component system [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs development
Development

No branches or pull requests

3 participants