Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Revisions: add more details to revision event #51183

Closed
annezazu opened this issue Jun 1, 2023 · 3 comments
Closed

Style Revisions: add more details to revision event #51183

annezazu opened this issue Jun 1, 2023 · 3 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jun 1, 2023

What problem does this address?

Currently, the revision history for styles doesn't provide any context as to what each revision holds, instead relying on a visual display of the changes:

Screen Shot 2023-06-01 at 11 12 00 AM

While it's helpful to have visuals, it's hard to spot the changes visually without any context. For example, perhaps you made Style changes to a block that's not on the template you're looking at or the changes aren't visible in the part of the template you're looking at. Here's an example:

style.example.mov

What is your proposed solution?

I think there should be a way to see more information at a glance when viewing different revisions, perhaps only the currently active one before thinking through comparison style flows. This ties into work to provide more granular info with saving too: #29388

@annezazu annezazu added Needs Design Feedback Needs general design feedback. [Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 1, 2023
@mtias
Copy link
Member

mtias commented Jun 2, 2023

It can be useful for assistive technologies as well to have a summary of changes to identify. This is sort of related to also listing somewhere in global styles what things are changed. The "reset to defaults", for example, could open a modal to confirm that lists those changes as well.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 19, 2023
@ramonjd
Copy link
Member

ramonjd commented Jul 24, 2023

For the text summary side of things, I did do a very quick test of that when first pulling things together: #50089 (comment)

Some revisions could contain dozens of changes, so the gist of it was we'd scan the top level of global styles JSON for top-level styles and, for each item in the revisions list, print something like:

"This revision contains changes to typography, color, and the Paragraph block."

Even that could get verbose and adding the iterative logic to insert this content would slow down rendering. Perhaps we could rather insert the content changes on demand, that is, when a user selects an individual revision. Would need some design cycles to get the UI right.

@annezazu
Copy link
Contributor Author

Closing this out in favor of a more recent and duplicated issue: #55647

@SaxonF SaxonF moved this to In Progress in Design priorities Dec 7, 2023
@annezazu annezazu moved this to 📥 Todo in WordPress 6.5 Editor Tasks Jan 5, 2024
@annezazu annezazu moved this from 📥 Todo to ✅ Done in WordPress 6.5 Editor Tasks Jan 5, 2024
@SaxonF SaxonF moved this from In Progress to Done in Design priorities Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants