Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove value sync hook in Link Control #51256

Closed
getdave opened this issue Jun 6, 2023 · 1 comment · Fixed by #51387
Closed

Remove value sync hook in Link Control #51256

getdave opened this issue Jun 6, 2023 · 1 comment · Fixed by #51387
Assignees
@Mamaduka @getdave
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Jun 6, 2023

Let's look to remove the value sync that was only needed to fix an obscure bug that has other guards.

Do you know if this sync hook is still needed? Now that value is an object; the synchronization can cause the content loss.

Originally posted by @Mamaduka in #50668 (comment)
@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Jun 6, 2023
@getdave
Copy link
Contributor Author

getdave commented Jun 6, 2023

Related to #51155

This was referenced Jun 6, 2023
Merged
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 9, 2023
@Mamaduka Mamaduka mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

@getdave getdave

Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Status] In Progress Tracking issues with work in progress [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove value syncing in Link Control WordPress/gutenberg
2 participants
@Mamaduka @getdave