Reusable block/Pattern: option to create does not appear when editing content in site editor

[glendaviesnz]

Description

When editing content in the site editor the option to Create Reusable block does not appear in the block overflow menu.

Step-by-step reproduction instructions

• In the Site editor select the Pages option from the left menu
• Choose a page to edit and while editing the page content add a new block and in the block overflow menu notice that there is not option to Create Reusable block

Screenshots, screen recording, code snippet

Environment info

WP 6.2.2 & Gutenberg 16.0.0-rc.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[carolinan]

If I am reading the code correctly, it is because the rootClientId is not provided for this check?

gutenberg/packages/reusable-blocks/src/components/reusable-blocks-menu-items/reusable-block-convert-button.js

Line 68 in af38c95

canInsertBlockType( 'core/block', rootClientId ) &&

[glendaviesnz]

If I am reading the code correctly, it is because the rootClientId is not provided for this check?

gutenberg/packages/reusable-blocks/src/components/reusable-blocks-menu-items/reusable-block-convert-button.js

Line 68 in af38c95

canInsertBlockType( 'core/block', rootClientId ) &&

Seems like getBlockEditingMode was the selector that was returned disabled if rootClientID was not explicitly set, but not 100% sure why yet - but a PR that adds the rootClientID is here, and this does fix the issue, but I need to do some more testing to make sure there are no other side effects.