Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title bar: accessibility naming of command center prompt #51394

Open
annezazu opened this issue Jun 10, 2023 · 4 comments · May be fixed by #54323
Open

Title bar: accessibility naming of command center prompt #51394

annezazu opened this issue Jun 10, 2023 · 4 comments · May be fixed by #54323
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

In talking with @joedolson at WCEU, we went through the Title Bar and the accessible name to open the command center has a different accessible name on every page because it's inheriting that from the title bar. The name needs to incorporate the visible text so it has to include the name of that page but that doesn't make any sense when it's opening up the command prompt. Ultimately, it has nothing to do with the Page itself since the command center is site wide. Clicking on the title of the page or template makes it seem as if it would relate to the page or template itself when really it's site wide. This especially matters since it's using the H1.

One options to consider is to have a dedicated control that conveys it's site wide and doesn't contain other unrelated text. We could reuse what's in the sidebar with the search icon instead of command-k perhaps:

Screen Shot 2023-06-10 at 12 52 41 PM

This relates to the overall work around stabilizing the Title Bar: #50378

cc @WordPress/gutenberg-design

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 10, 2023
@jameskoster
Copy link
Contributor

I acknowledge it will always be 'site wide', but I'm curious whether the command palette showing contextual commands in (#50407) would have any bearing on this?

@joedolson
Copy link
Contributor

Contextual commands just seem inclusive within the global nature of this.

But more importantly to me is that the control to activate the command center needs to have an accessible name that's consistent and relevant. As this is currently specified, the name of the control is different on every screen.

From a non-visual perspective, what would I expect the button named "About Us" that's in the H1 to do? How does that make any relevant sense to a user?

The heading needs to be used for orientation and context, and it shouldn't also be used as a control surface.

@joedolson
Copy link
Contributor

It doesn't seem like there's been any movement on this, but I'd consider this a major accessibility bug in the command palette trigger. Button names need to reflect what they do, and the button to trigger the command palette doesn't have a fixed name. The control name "Editing template: Blog Home Ctrl + K" conveys the clear impression that pressing Ctrl K will allow you to edit the blog home template.

These need to be separated: the H1 providing location context must be separate from the control that opens the command palette.

@annezazu
Copy link
Contributor Author

@richtabor and @youknowriad -- would you all have time to dig into this as part of continued design iterations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Accessibility Feedback Need input from accessibility [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants