Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: the Styles welcome guide can't be opened manually #51702

Open
afercia opened this issue Jun 20, 2023 · 3 comments
Open

Site Editor: the Styles welcome guide can't be opened manually #51702

afercia opened this issue Jun 20, 2023 · 3 comments
Labels
[Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jun 20, 2023

Description

The post editor, the site editor, and the widgets editor, show a 'Welcome guide' modal dialog when they load for the first time.

After the welcome guides are dismissed, users can always reopen them from the editor options menu. However, this appears to not work for the Styles welcome guide in the Site editor.

Step-by-step reproduction instructions

  • Activate a non-block based theme e.g. Twenty Twenty-One.
  • Go to Appearance > Widgets.
  • If the Welcome guide opens by default, just close it.
  • Glick Options > Welcome guide.
  • Observe the widgets welcome guide opens. So far so good.
  • Activate a block based theme e.g. Twenty Twenty-Three.
  • Go to the Post editor. If the Welcome guide opens by default, just close it.
  • Glick Options > Welcome guide.
  • Observe the block editor welcome guide opens. So far so good.
  • Switch the post editor to the template editor: in the Settings sidebar Post tab, click the template name and then click 'Edit template'.
  • The editor switches to the Template editor. If the Welcome guide opens by default, just close it.
  • Glick Options > Welcome guide.
  • Observe the template editor welcome guide opens. So far so good.
  • Go to the Site editor. If the Welcome guide opens by default, just close it.
  • Glick Options > Welcome guide.
  • Observe the site editor welcome guide opens. So far so good.
  • Switch the editor to the Styles editor by clicking 'Styles' in the top bar.
  • If the Styles Welcome guide opens by default, just close it.
  • Glick Options > Welcome guide.
  • Observe the Site editor welcome guide opens. Expected: the Styles welcome guide to open instead.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Edit Site /packages/edit-site labels Jun 20, 2023
@richtabor
Copy link
Member

Coincidently, this PR adds a command via the Wayfinder command palette to learn more about styles, which opens the styles intro guide: #51637

@afercia
Copy link
Contributor Author

afercia commented Jul 5, 2023

Noting that after #52014 there are now a few new welcome guides, for a total of seven:

  • edit-post
    • welcomeGuide
    • welcomeGuideTemplate
  • edit-site
    • welcomeGuide
    • welcomeGuideStyles
    • welcomeGuidePage
    • welcomeGuideTemplate
  • edit-widgets
    • welcomeGuide

Most notably, the Site editor has now 4 welcome guides. We should make sure that, depending on the editor state, the 'Welcome guide' menu item in the Options menu opens the right welcome guide.

@afercia
Copy link
Contributor Author

afercia commented Jul 5, 2023

Considering also #52328 (comment) looks like there's the need for new components for the menu items that open the Welcome guides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants