Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: remove "apply globally" option from block settings #52139

Closed
annezazu opened this issue Jun 29, 2023 · 1 comment · Fixed by #52160
Closed

Patterns: remove "apply globally" option from block settings #52139

annezazu opened this issue Jun 29, 2023 · 1 comment · Fixed by #52160
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Description

When creating a new pattern using 16.1 and syncing it, an option to "apply globally" popped up in the block settings. This doesn't make sense in this context and should be removed.

Step-by-step reproduction instructions

  1. Create a new pattern from three dot menu.
  2. Ensure focus remains on the pattern (it should).
  3. Open sidebar and notice under advanced an option to apply globally greyed out.

Screenshots, screen recording, code snippet

Screen Shot 2023-06-29 at 11 15 29 AM

Environment info

  • WP 6.2.2
  • GB 16.1
  • TT3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jun 29, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jun 29, 2023
@richtabor
Copy link
Member

Related: Template parts should also have this omitted.

Could we use the same logic that omits copy and paste styes from the block toolbar options re #51503? cc @pbking

CleanShot 2023-06-29 at 14 50 24

@carolinan carolinan self-assigned this Jun 30, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 30, 2023
@ndiego ndiego moved this from ❓ Triage to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Jul 3, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.3.x Editor Tasks Jul 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
No open projects
4 participants