Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Explore options to enforce pattern name uniqueness #52360

Open
aaronrobertshaw opened this issue Jul 6, 2023 · 2 comments
Open

Patterns: Explore options to enforce pattern name uniqueness #52360

aaronrobertshaw opened this issue Jul 6, 2023 · 2 comments
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.

Comments

@aaronrobertshaw
Copy link
Contributor

Pattern names should generally be unique. As we are leveraging the wp_block post type for patterns now, there currently isn't any uniqueness constraint.

See further discussion in #52270

Duplicate names seems like something to avoid generally. But I noticed you can reuse existing names when creating a pattern manually too, so perhaps it's something to address separately?

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jul 6, 2023
@annezazu
Copy link
Contributor

annezazu commented Jul 6, 2023

Is this intended for inclusion in 6.3? I was going to add it to the 6.3 board but wasn't quite sure. Feel free to do so.

@aaronrobertshaw
Copy link
Contributor Author

Thanks for the question @annezazu 👍

No, this is a future follow-up. My understanding is reusable blocks have long allowed duplicate names so we'll have some rough edges that need consideration if we're to impose this uniqueness constraint. Leaving things as they are now doesn't box us into a corner.

When I created this, I also put it under future follow-ups in the Patterns tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants