Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for post template removal #52390

Closed
annezazu opened this issue Jul 6, 2023 · 2 comments · Fixed by #52666
Closed

Add warning for post template removal #52390

annezazu opened this issue Jul 6, 2023 · 2 comments · Fixed by #52666
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Jul 6, 2023

While testing 6.3 beta 3, I noticed I could still remove the post template block and didn't receive a warning. This seems like a bit of an oversight as part of this PR: #51145 IMO we should have a warning for both, especially since if you remove the post template block, the experience is still broken:

no.warning.with.post.template.mov
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 6, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jul 6, 2023
@annezazu
Copy link
Contributor Author

@tellthemachines in case you can spin up a quick PR to do the same for post template after your earlier work!

@annezazu annezazu moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 14, 2023
@tellthemachines
Copy link
Contributor

Hmm the implementation in Gutenberg has diverged from the one in #51145 which went into 6.3, so if we want to fix this for 6.3 we either need to include #51841 or we'll have to do a custom patch for it directly in the release branch, and then fix it separately in Gutenberg. Looking at #51841 I think it should be safe to include and will definitely make things easier to not have two divergent implementations 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants