Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control for renaming a page in the Site Editor #52763

Closed
jameskoster opened this issue Jul 19, 2023 · 19 comments
Closed

Add control for renaming a page in the Site Editor #52763

jameskoster opened this issue Jul 19, 2023 · 19 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Jul 19, 2023

Sometimes a page template may not include a Title block. In this scenario there's no way to update the page title in the site editor.

For potential solutions we can look at existing patterns. Templates can be renamed via their detail panels like so:

Screenshot 2023-07-19 at 15 10 52

This could work well for pages too, but it would be good to include a way to edit the title in the full screen editor too. Whatever solution is found for that context could be applied to custom templates as well, as they also cannot be renamed currently.

Finally it may be reasonable to surface a rename action in the Command Palette.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 19, 2023
@jasmussen
Copy link
Contributor

I would think that we need a generic solution for changing page/post titles when there isn't a title block, one that also works for "asides". I feel like there's a separate issue for this that would be good to connect up with this one? The details view doesn't feel like the ideal place for this, IMO.

@jameskoster
Copy link
Contributor Author

The details view doesn't feel like the ideal place for this

How come? To me it seems perfectly reasonable to edit the title here, similar to how you can edit a post title in the list view. Forcing users into the editor feels a bit tedious.

That's not to say you can't edit the title in the editor too. I think we need both.

@jasmussen
Copy link
Contributor

I wouldn't mind that this interface was an additional way of changing the title, and inline renaming here comes to mind. Though I would still instinctually think of the full editor having an interface for it first, no?

@jameskoster
Copy link
Contributor Author

Inline editing can work. Though initially it probably makes sense to re-use the existing pattern we have in place for templates, template parts, patterns, then refine holistically afterwards?

Though I would still instinctually think of the full editor having an interface for it first, no?

To be honest I see them as equal priority. It would be a bit strange imo if you can change the title in one but not the other.

@jasmussen
Copy link
Contributor

Can we add an item in the Summary panel if the title block is not present?

Screenshot 2023-09-13 at 13 40 36

Title > [title button which opens a naming modal]?

@jameskoster
Copy link
Contributor Author

Yup, I think that can work for the editor, and the pattern we have for templates/patterns can work for the details panel.

Screenshot 2023-09-13 at 12 50 35 Screenshot 2023-09-13 at 12 51 05

@jameskoster
Copy link
Contributor Author

Alternatively we might place the affordance closer to the title card:

Screenshot 2023-09-13 at 12 53 33

But given discussion around the edit button in the details panel, perhaps the Summary panel is better.

@jameskoster
Copy link
Contributor Author

Connecting a dot here with post formats: A modal invoked from the Summary panel could house an option to toggle frontend visibility of the title:

Screenshot 2023-09-14 at 10 32 00

@ellenbauer
Copy link

As there could potentially be more actions for Templates would it maybe be an idea to add the Vertical 3 dots actions icon and a list of actions including edit with edit icon?

Similar to something I've seen in Notion:
Screenshot 2023-09-18 at 8 19 54 PM

I have to admit, I also have doubts that the Sidebar icon would be easier to understand for users compared to the current Edit icon.

@jameskoster
Copy link
Contributor Author

@ellenbauer you mean something like this?

Screenshot 2023-09-19 at 11 29 42

I think that could work, and the consistency with the details panel in the dark material makes sense. Here's that concept applied to other contexts:

Screenshot 2023-09-19 at 11 43 36

@SaxonF
Copy link
Contributor

SaxonF commented Sep 20, 2023

I like that. Still not sure about a "hide title" setting but that's a separate conversation :) . I think we're ready to move forward with this one.

@SaxonF SaxonF added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Sep 20, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Sep 20, 2023

PR here

@bph bph removed the Needs Dev Ready for, and needs developer efforts label Sep 21, 2023
@scruffian
Copy link
Contributor

The attached PR looks good, but I also think that the original idea is good - we saw a user looking for a rename option beneath the contextual menu in the Site View.

@jameskoster
Copy link
Contributor Author

Agreed, I don't think it should be necessary to open the full screen editor just to change a page title.

@annezazu
Copy link
Contributor

Removing this from the 6.5 editor board due to lack of activity around the PR. Happy to add back in if work picks back up!

@jameskoster
Copy link
Contributor Author

Site Editor: There's no way to change page title if the template does not include a Title block

This issue is actually resolved after all the post/site editor unification. If you toggle the template preview off, it's possible to add a title.

I still think we should enable users to edit the title from the details panel, and from data views, but those can be tackled separately.

@richtabor
Copy link
Member

This issue is actually resolved after all the post/site editor unification. If you toggle the template preview off, it's possible to add a title.

It's less than ideal though; I don't know that most folks know what turning off a template preview means. I like the approach from PR #54648. We already have a UX pattern for using the vertical ellipsis in that area.

@richtabor richtabor reopened this Mar 21, 2024
@richtabor richtabor changed the title Site Editor: There's no way to change page title if the template does not include a Title block Add control for renaming a page in the Site Editor Mar 21, 2024
@jameskoster
Copy link
Contributor Author

Yup that approach is aligned with the work in #59689. Unsure why it never got merged 🤔

@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented Apr 5, 2024

Marking this as complete as #60230 and #60232 have been merged.

A command to rename pages is also currently in the pipeline to address #60089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

9 participants