-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control for renaming a page in the Site Editor #52763
Comments
I would think that we need a generic solution for changing page/post titles when there isn't a title block, one that also works for "asides". I feel like there's a separate issue for this that would be good to connect up with this one? The details view doesn't feel like the ideal place for this, IMO. |
How come? To me it seems perfectly reasonable to edit the title here, similar to how you can edit a post title in the list view. Forcing users into the editor feels a bit tedious. That's not to say you can't edit the title in the editor too. I think we need both. |
I wouldn't mind that this interface was an additional way of changing the title, and inline renaming here comes to mind. Though I would still instinctually think of the full editor having an interface for it first, no? |
Inline editing can work. Though initially it probably makes sense to re-use the existing pattern we have in place for templates, template parts, patterns, then refine holistically afterwards?
To be honest I see them as equal priority. It would be a bit strange imo if you can change the title in one but not the other. |
Alternatively we might place the affordance closer to the title card: But given discussion around the edit button in the details panel, perhaps the Summary panel is better. |
@ellenbauer you mean something like this? I think that could work, and the consistency with the details panel in the dark material makes sense. Here's that concept applied to other contexts: |
I like that. Still not sure about a "hide title" setting but that's a separate conversation :) . I think we're ready to move forward with this one. |
PR here |
The attached PR looks good, but I also think that the original idea is good - we saw a user looking for a rename option beneath the contextual menu in the Site View. |
Agreed, I don't think it should be necessary to open the full screen editor just to change a page title. |
Removing this from the 6.5 editor board due to lack of activity around the PR. Happy to add back in if work picks back up! |
This issue is actually resolved after all the post/site editor unification. If you toggle the template preview off, it's possible to add a title. I still think we should enable users to edit the title from the details panel, and from data views, but those can be tackled separately. |
It's less than ideal though; I don't know that most folks know what turning off a template preview means. I like the approach from PR #54648. We already have a UX pattern for using the vertical ellipsis in that area. |
Yup that approach is aligned with the work in #59689. Unsure why it never got merged 🤔 |
Marking this as complete as #60230 and #60232 have been merged. A command to rename pages is also currently in the pipeline to address #60089 |
Sometimes a page template may not include a Title block. In this scenario there's no way to update the page title in the site editor.
For potential solutions we can look at existing patterns. Templates can be renamed via their detail panels like so:
This could work well for pages too, but it would be good to include a way to edit the title in the full screen editor too. Whatever solution is found for that context could be applied to custom templates as well, as they also cannot be renamed currently.
Finally it may be reasonable to surface a rename action in the Command Palette.
The text was updated successfully, but these errors were encountered: