Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Revisions: Offer comparison views #53484

Open
2 tasks
jameskoster opened this issue Aug 9, 2023 · 6 comments
Open
2 tasks

Style Revisions: Offer comparison views #53484

jameskoster opened this issue Aug 9, 2023 · 6 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Observing the changes between style revisions is not always easy, especially if they are subtle. Let's explore how to improve this experience by offering:

@jameskoster jameskoster added Needs Design Needs design efforts. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Aug 9, 2023
@ramonjd
Copy link
Member

ramonjd commented Aug 15, 2023

Thanks for opening this!

Copying over some idea/links from previous discussion for reference:

Discussed in:

It's possible to use WordPress's existing revisions.php page to compare the global styles custom post, however it means comparing changes to JSON, which may not be accessible to everyone.

Screenshot 2023-07-24 at 15 56 22

As mentioned previously, it is possible to load two versions in two iframes:

2023-05-01.16.16.51.mp4

@c4rl0sbr4v0 has also explored a comparison engine to diff two theme.json trees: tenberg/pull/52829#issuecomment-1659027089

We probably need to undertake more investigation in order to balance performance and utility.

As a starting taster will might like to display top-level changes to the user, e.g.,

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] History History, undo, redo, revisions, autosave. labels Aug 30, 2023
@ricjcs
Copy link

ricjcs commented Dec 7, 2023

It would be nice if it were also possible to compare the code, as it currently happens.

@ramonjd
Copy link
Member

ramonjd commented Dec 8, 2023

It would be nice if it were also possible to compare the code, as it currently happens.

Do you mean have a link to the revisions page, e.g.,

Screenshot 2023-12-08 at 11 17 52 am

It's not currently linked to anywhere, but it's possible to view via /wp-admin/revision.php?revision=${ revisionId }

I've mentioned including a link to this page in #56577 (comment)

@ricjcs
Copy link

ricjcs commented Dec 8, 2023

I've mentioned including a link to this page in #56577 (comment)

Perfect :) Thanks for the reply!

@annezazu
Copy link
Contributor

We're out of time for 6.5 but I'm excited to see this coming together for future releases. Punting!

@colorful-tones
Copy link
Member

Hi folks,
We are only one week away from the Beta 1 cut-off date for WordPress 6.6. This issue hasn’t seen any movement in a while, so we (the editor triage leads of the 6.6 release) have decided to remove it from the WordPress 6.6 Editor Tasks project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
Status: Now
Development

No branches or pull requests

6 participants