Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook regressions after TypeScript 5.1 update #53502

Closed
mirka opened this issue Aug 10, 2023 · 2 comments · Fixed by #53520
Closed

Storybook regressions after TypeScript 5.1 update #53502

mirka opened this issue Aug 10, 2023 · 2 comments · Fixed by #53520
Assignees
Labels
Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers

Comments

@mirka
Copy link
Member

mirka commented Aug 10, 2023

The recent update to TypeScript 5.1 (#52621, #53445) has caused some breakage in our Storybook:

  • The components props tables do not show information sourced from TypeScript data anymore. We are missing a huge chunk of props documentation and controls.
  • Event handlers such as onChange are not showing up as expected in the Actions panel. It seems like everything with configured with actions: { argTypesRegex: '^on.*' } is broken. In some cases, when the handlers are called in component story code without an optional (onChange() vs. onChange?.()), the story will crash on the first change event.

How to address

We'll first try to update Storybook to v7 to see if these issues might be resolved naturally. This upgrade was planned from before and we are now unblocked due to the Node upgrade in #53426.

@mirka mirka added [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Aug 10, 2023
@mirka mirka self-assigned this Aug 10, 2023
@mirka mirka linked a pull request Aug 10, 2023 that will close this issue
1 task
@noahtallen
Copy link
Member

The components props tables do not show information sourced from TypeScript data anymore. We are missing a huge chunk of props documentation and controls.

Sorry I missed this!

@mirka
Copy link
Member Author

mirka commented Aug 10, 2023

No problem at all, these things aren't very obvious 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants