Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: A border is drawn when there are no fonts available #54527

Closed
t-hamano opened this issue Sep 17, 2023 · 0 comments · Fixed by #56825
Closed

Font Library: A border is drawn when there are no fonts available #54527

t-hamano opened this issue Sep 17, 2023 · 0 comments · Fixed by #56825
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

Description

If the currently active theme does not define fonts, an unnatural border will be displayed.

actual

I would suggest either of the following approaches:

Just hide the border

proposal_1

Show some text

proposal_2

Step-by-step reproduction instructions

  • Activate Emptyempty theme.
  • Open the Site Editor.
  • Global Styles > Typography

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Fonts API labels Sep 17, 2023
This was referenced Sep 18, 2023
Closed
Closed
@annezazu annezazu added [Feature] Typography Font and typography-related issues and PRs and removed [Feature] Fonts API labels Sep 25, 2023
@mikachan mikachan mentioned this issue Nov 6, 2023
Closed
25 tasks
@HrithikDalal HrithikDalal mentioned this issue Dec 26, 2023
Open
This was referenced Dec 27, 2023
Closed
Merged
@t-hamano t-hamano linked a pull request Dec 27, 2023 that will close this issue
#56734 When there is no font, the border should not appear. Display further guidance text. #56825
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
No milestone
2 participants
@annezazu @t-hamano