Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Link Control elements & labels to use correct gray color #54589

Closed
getdave opened this issue Sep 19, 2023 · 3 comments · Fixed by #55867
Closed

Update Link Control elements & labels to use correct gray color #54589

getdave opened this issue Sep 19, 2023 · 3 comments · Fixed by #55867
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Sep 19, 2023 •
edited
Loading

Let's update all labels and elements in LinkControl to use $gray-900.

I did notice that the other elements/labels are not using $gray-900 as well. May be worth a quick follow-up to do that.

CleanShot 2023-09-18 at 16 03 01

Originally posted by @richtabor in #54545 (review)
@getdave getdave added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts labels Sep 19, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 20, 2023
@sandnb
Copy link

sandnb commented Sep 25, 2023

Hello getdave , Can I know if anyone is working on this Issue?

@getdave
Copy link
Contributor Author

getdave commented Sep 25, 2023

@sandnb No one has picked it up as far as I know. Would you be open to raising a PR?

If so then please tag myself and @richtabor 🙇

@sandnb
Copy link

sandnb commented Sep 26, 2023

Sure @getdave I would love to raise a PR on this issue and will tag you. Thank You.

@joanrodas joanrodas mentioned this issue Nov 5, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Link Control labels to use gray-900 joanrodas/gutenberg
3 participants
@getdave @jordesign @sandnb