Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing style variations from the block toolbar #54986

Open
richtabor opened this issue Oct 2, 2023 · 4 comments
Open

Consider removing style variations from the block toolbar #54986

richtabor opened this issue Oct 2, 2023 · 4 comments
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

Are these variations useful in the block toolbar, or are they just adding noise by providing an another way to apply a style variation?

I lean towards removing them from the block toolbar and reserving this space for when transforms and alternate patterns are available. It seems like additional noise as-is.

CleanShot 2023-09-13 at 12 38 10
@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Feature] Block Variations Block variations, including introducing new variations and variations as a feature labels Oct 2, 2023
@jasmussen
Copy link
Contributor

As is, I'd agree it's mostly noise. Conceptually, though, I don't know that either the styles panel in the inspector, or even the dropdown (whether transforms, variations, patterns) are in a good place. But conceptually those all still feel related to me: you transform from one thing into another, and the "transform control center", wherever that lives, could be a place you go to see what other options this block might have. I've noted this in the past and we haven't had bandwidth to look at it, but I still believe it to be true. Whether we can remove this one in the mean time, I don't know — it doesn't offend me that it exists here, even if it does still look like an unfulfilled opportunity.

@richtabor
Copy link
Member Author

But conceptually those all still feel related to me: you transform from one thing into another, and the "transform control center", wherever that lives, could be a place you go to see what other options this block might have.

I suppose I see transforms a bit more formally, where the intent is to change the block into something else, rather than set a different visual style for it.

Like in these examples below, the styles seem quite disconnected from the other more intentional options. Makes me wonder if "Styles" is a subset of transforms, or somehow related, or alternate types of transforms (which maybe they are?).

Perhaps if we have nested dropdowns this would be cleared up, but then again I don't think this popover should become an alternative/extension to the block options menu.

CleanShot 2023-10-04 at 08 03 37
CleanShot 2023-10-04 at 08 04 13

@jasmussen
Copy link
Contributor

I recall some of the very first G2 redesign mockups had those style transforms in a nested dropdown, complete with previews and everything. One of the benefits of keeping it accessible from the block toolbar is that you'd still have access to it if you toggle off the inspector, for a neater writing experience.

I do agree the current appearance is anemic.

@spencerfinnell
Copy link

To me the disconnect comes from the additional divider between the transformation options. Is the first one the primary suggestion?

Two clearly labeled, and clearly grouped sections makes sense in that dropdown to me. However, I think the tooltip itself could be made clearer about what is possible at all in that menu:

Screenshot 2023-10-05 at 11 25 02 AM

@foosantos foosantos added the [Type] Enhancement A suggestion for improvement. label Oct 7, 2023
@talldan talldan added [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks and removed [Feature] Block Variations Block variations, including introducing new variations and variations as a feature labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants