Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gallery link controls to the block toolbar #55022

Closed
richtabor opened this issue Oct 3, 2023 · 3 comments · Fixed by #62762
Closed

Move gallery link controls to the block toolbar #55022

richtabor opened this issue Oct 3, 2023 · 3 comments · Fixed by #62762
Assignees
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Oct 3, 2023

Related to #55020, I propose moving the gallery block's "Link to" control from the inspector to a more familiar, and consistent, link control in the block toolbar. This would consolidate the varying linking controls found in image and galleries today, while also making way for applying "Expand on click" to all images within a gallery block.

A follow-up to this would be to include "Expand on click" at the gallery parent level here, just like single image blocks will have in #55020.

Before

CleanShot 2023-10-03 at 16 25 30

Proposed

Lightbox for galleries, i4
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Block] Gallery Affects the Gallery Block - used to display groups of images labels Oct 3, 2023
@randomburner
Copy link

These are great ideas, and I cannot understand why lightbox control at the Gallery level wasnt introduced already.
I have a gallery with 30 images, do I then need to select every individual one to allow for the lightbox?

@richtabor
Copy link
Member Author

These are great ideas, and I cannot understand why lightbox control at the Gallery level wasnt introduced already.

Thanks! It's just a matter of refining it first in time for the 6.4 release. Now that it's in a decent place, we can level-up and bring it to the gallery block.

@RCNeil
Copy link

RCNeil commented Apr 3, 2024

I offer no value other than to second this notion. It also seems that the theme.json settings to modify the core/image lightbox settings to enabled automatically no longer work since the "Expand On Click" setting was moved to the block toolbar under Link Settings for each individual Image block.

@akasunil akasunil self-assigned this Jun 22, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants