Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lowercase capitalization on Featured Image "Link to..." control #55057

Open
richtabor opened this issue Oct 4, 2023 · 3 comments
Open

Use lowercase capitalization on Featured Image "Link to..." control #55057

richtabor opened this issue Oct 4, 2023 · 3 comments
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance

Comments

@richtabor
Copy link
Member

The post type value should be lowercased, like "Link to page".

CleanShot 2023-10-04 at 14 16 09
@richtabor richtabor added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance [Block] Post Featured Image Affects the Post Featured Image Block labels Oct 4, 2023
@richtabor richtabor added this to Polish Oct 4, 2023
@richtabor richtabor moved this to Needs development in Polish Oct 4, 2023
@properlypurple
Copy link
Contributor

It looks an opposite of this was reported in #49587 and it was fixed in #49591

@richtabor Is there any new discussion/decision on how this should be?

@richtabor
Copy link
Member Author

richtabor commented Oct 9, 2023 •
edited
Loading

It shouldn't be programmatically lowercased for sure.

@colinduwe
Copy link
Contributor

The control's label is using the post type's singular_name label which is typically capitalized (see here)

Since the direction in #49587 and from @richtabor is not to programmatically lowercase it, is this at a dead end? Or is there a lowercase singular label that I'm forgetting about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Post Featured Image Affects the Post Featured Image Block Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Copy Issues or PRs that need copy editing assistance
Projects
Polish
Status: Needs development
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richtabor @colinduwe @properlypurple