Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox as image block variation #55216

Open
hanneslsm opened this issue Oct 10, 2023 · 1 comment
Open

Lightbox as image block variation #55216

hanneslsm opened this issue Oct 10, 2023 · 1 comment
Labels
[Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

A lot of effort is currently put into the Lightbox feature, which is great. I can't possible see everything thats going on, but I read some PRs and issues. Right now, there are thoughts on how to handle links and where to find settings. In this issue #55020 (comment), I had the idea that a image with lightbox could just be a block variation of the Image block. The counterpoint was that block variations look different from each other.
But after I just saw the draft PR #55212 I want to bring up this idea again.
I feel like block variations is a powerful tool that could be utilized more to enhance the UX.

Maybe I'm completely wrong. This issue aims to start this discussion.

@richtabor
Copy link
Member

I'd imagine you'd want to invoke a visual style, say the "Rounded" default variation for the image block, but then if you want it lightbox as well — you can't.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Block] Image Affects the Image Block labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants