Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: cover image text and inline toolbar misplaced #5791

Closed
afercia opened this issue Mar 25, 2018 · 5 comments · Fixed by #9196
Closed

IE11: cover image text and inline toolbar misplaced #5791

afercia opened this issue Mar 25, 2018 · 5 comments · Fixed by #9196
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Milestone

Comments

@afercia
Copy link
Contributor

afercia commented Mar 25, 2018

In IE11, the cover image text and inline toolbar appear at the top instead of vertically centered:

screenshot 90

For a list of known flexbox bugm see https://github.com/philipwalton/flexbugs

@afercia afercia added the [Type] Bug An existing feature does not function as intended label Mar 25, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Apr 16, 2018
@mtias mtias added Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. labels Jul 18, 2018
@kjellr
Copy link
Contributor

kjellr commented Aug 6, 2018

I can reproduce. Also, note that the background behind the inline options for the title (Bold, Italic, Strikethrough, Link), has a visual issue as well. Not sure if it's related or not:

cover-image-title

@webmandesign
Copy link
Contributor

Hey guys,

The bug is being triggered by min-height applied on flexbox container in IE11. Fix seems to be pretty straightforward simply by applying aditional height styles. philipwalton/flexbugs#231

Have created #9196 pull request to fix this.

Regards,

Oliver

@webmandesign
Copy link
Contributor

Actually, I've just retested it and it seems the better fix would be using ::after pseudo element philipwalton/flexbugs#231 (comment) to account for cases with larger cover image text.

Tested and works for me.

@brandonpayton
Copy link
Member

Also, note that the background behind the inline options for the title (Bold, Italic, Strikethrough, Link), has a visual issue as well.

I played with this a bit and was able to avoid the visual issue by setting flex-shrink: 0 for direct children of .editor-rich-text__inline-toolbar. I don't know why this is necessary in IE11 though.

After making the entire toolbar visible no matter the width of the entered text, there was still an issue of centering it. The left edge of the toolbar was aligned with the left edge of the text field regardless of the justify-content: center property on the toolbar. It's possible IE11 won't center when the flex items overflow their container.

@kjellr
Copy link
Contributor

kjellr commented Oct 24, 2018

Just noting that @ianbelanger79 came across this issue while testing the Twenty Nineteen theme. Would be great to have it fixed in Gutenberg for 5.0, rather than pushing an individual theme stylesheet fix.

WordPress/twentynineteen#269

@earnjam earnjam added this to the WordPress 5.0 RC milestone Nov 11, 2018
@mtias mtias added Needs Dev Ready for, and needs developer efforts and removed Needs Testing Needs further testing to be confirmed. labels Nov 12, 2018
@mtias mtias modified the milestones: WordPress 5.0 RC, WordPress 5.0 Nov 16, 2018
@jorgefilipecosta jorgefilipecosta removed their assignment Nov 20, 2018
@jorgefilipecosta jorgefilipecosta added the [Status] In Progress Tracking issues with work in progress label Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants