Regression regarding layout in the Site Editor #58044
Comments
t-hamano
added
[Type] Regression
|
Thanks for flagging these regressions. Any help addressing some of them would be appreciated. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@t-hamano have all the regressions noted been addressed in the merged PRs? If so, can we move this to ‘Done’? Or is further testing required? |
No, although resolved issues are grouped under the "Fixed" accordion, the following issues still remain.
|
Update: #58139 stabilizes the Patterns page with DataViews, so this issue effectively no longer needs to be fixed. |
|
The issues that currently remain are regarding the responsive layout and the mobile viewport. Especially when it comes to the mobile layout, there are two serious issues:
My understanding is that the data view has been stabilized on all pages and shipped in WP.6.5. I believe this issue should be fixed in WP6.5, so I would like to label this issue as a high priority. 6e8b0019e2ef259280095490dca77e80.mp4 |
t-hamano
added
the
[Priority] High
jameskoster
added
the
[Type] Bug
annezazu
changed the title
|
Might this be related or does this need a new issue? Noticed it today using WP playground on 6.5-alpha-57531 sidebar.site.editor.mov |
This seems to occur when the page slug is extremely long. I was able to see this problem in WP6.4.3 as well, so I don't think it's related to this issue. Therefore, I think it would be better to submit a new issue. |
|
Done :) #58748 |
|
I have had zero testing with the new admin views and thought this would be a great way to get started 🙃 . I'm unclear about the testing instructions, but I detailed what I tested below and hopefully it helps. Templates are not displayed in the mobile layout.I tested this against the following scenarios and obtained the same experience on all of them.
This 👇 is what I saw for all of those 👆 scenarios
Canvas area and data view area overlapWith viewport width at approximately between 800px and 1100px. I tested this against the following scenarios and obtained the same experience on all of them.
This 👇 is what I saw for all of those 👆 scenarios Screen.Recording.2024-02-09.at.5.21.19.PM.movOn the "Patterns" page, nothing happens when you click on a pattern categoryI tested this against the following scenarios and obtained the same experience on all of them.
This 👇 is what I saw for all of those 👆 scenarios. I confirmed that clicking on any of the pattern categories did nothing for all of the above scenarios. 🐛
Data view is not displayed on "Manage all pages" pageI tested this against the following scenarios:
This 👇 is what I saw for these two 👆 scenarios. all-pages-site-editor.mp4I also tested against the following scenarios:
This 👇 is what I saw for these two 👆 scenarios.
|
github-actions
bot
added
the
[Status] In Progress
github-project-automation
bot
moved this from 📥 Todo
to ✅ Done
in WordPress 6.5 Editor Tasks
After #57938 was merged, there seem to be some layout breakdowns in the site editor. This issue summarizes the problems I discovered.
Note
The following issue was discovered with the "New admin view" experimental flag enabled. There may be other issues if this experimental flag is turned off. One of them is attempted to be resolved in #58039.
Templates are not displayed in the mobile layout
In fact, the expected screenshot itself doesn't seem right. I think the preview area itself needs to be hidden in the mobile layout.
Canvas area and data view area overlap
You will see this issue when the viewport width is approximately between 800px and 1100px.
Fixed
The headers and the footer are not fixed on Templates, Template Parts, and Pattern pages
Top right and bottom right corners are not rounded
Presumably, this can only be reproduced in the Chrome browser on Windows OS. It happens on All Templates, Template Parts, and Pattern pages.
Extra space on top and right side
Pattern padding
#58139 stabilizes the Patterns page with DataViews, so this issue effectively no longer needs to be fixed.
Disable the data views experiment to see this:
With the margin added to
.edit-site-layout__areathe vertical stroke on the left doesn't quite reach the top/bottom of the viewport, and the pattern thumbnails are prematurely clipped.The text was updated successfully, but these errors were encountered: